Skip to content

test: explicitly use US location for session in tests #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 1 commit into from
May 1, 2024
Merged

test: explicitly use US location for session in tests #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/system/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,10 @@ def resourcemanager_client(

@pytest.fixture(scope="session")
def session() -> bigframes.Session:
return bigframes.Session()
context = bigframes.BigQueryOptions(
location="US",
Copy link
Contributor

@shobsi shobsi May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should already be the default

python-bigquery-dataframes/bigframes/session/__init__.py

Line 182 in c67e501

self._location = "US"

Copy link
Collaborator Author

@tswast tswast May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the line below that raises a warning. So this avoids that noise at least, even if it doesn't fix the issue.

)
return bigframes.Session(context=context)


@pytest.fixture(scope="session")
Expand Down