Skip to content

refactor: split read_gbq_table implementation into functions and move to separate module #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 7 commits into from
Apr 30, 2024
Merged

refactor: split read_gbq_table implementation into functions and move to separate module #642

tswast merged 7 commits into from
Apr 30, 2024

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Apr 26, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 26, 2024
@tswast tswast marked this pull request as ready for review April 29, 2024 22:30
@tswast tswast requested review from a team as code owners April 29, 2024 22:30
@tswast tswast requested a review from DevStephanie April 29, 2024 22:30
@tswast tswast requested review from Genesis929 and removed request for DevStephanie April 29, 2024 22:33
tswast
tswast commented Apr 30, 2024
View reviewed changes
chelsea-lin
chelsea-lin approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bigframes/session/_io/bigquery/read_gbq_table.py
# the same assumption and use these columns as the total ordering keys.
is_index_unique = len(index_cols) != 0
else:
is_index_unique = _check_index_uniqueness(
Copy link
Contributor

@chelsea-lin chelsea-lin Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This operation is also quiet expensive though.

Copy link
Collaborator Author

@tswast tswast Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I want to minimize any behavior changes in this PR. Filed b/338065601 to follow-up.

@tswast tswast merged commit 9a9f2bc into main Apr 30, 2024
@tswast tswast deleted the b335727141-refactor-read_gbq_table branch April 30, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Assignees

@liujiashang liujiashang

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @chelsea-lin @liujiashang