Skip to content

feat: custom query labels for compute options #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Genesis929 merged 6 commits into from
May 3, 2024
Merged

feat: custom query labels for compute options #638

Genesis929 merged 6 commits into from
May 3, 2024

Conversation

@Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Apr 24, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Updated doc screenshot.
https://screenshot.googleplex.com/4W6SEjLD4SBPPXZ
https://screenshot.googleplex.com/3RZL3k3kKJUSxJf

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 24, 2024
@Genesis929 Genesis929 changed the title Labels global huanc feat: Custom query labels for compute options Apr 24, 2024
@Genesis929 Genesis929 changed the title feat: Custom query labels for compute options feat: custom query labels for compute options Apr 24, 2024
@Genesis929 Genesis929 requested review from ashleyxuu and tswast April 25, 2024 00:23
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 25, 2024
@Genesis929 Genesis929 marked this pull request as ready for review April 25, 2024 21:43
@Genesis929 Genesis929 requested review from a team as code owners April 25, 2024 21:43
ashleyxuu
ashleyxuu approved these changes Apr 30, 2024
View reviewed changes
tests/system/small/test_session.py
bigframes.options.compute.assign_extra_query_labels(test1=1, test2="abc")
bigframes.options.compute.extra_query_labels["test3"] = False

job_labels = session.read_gbq(scalars_table_id).query_job.labels # type:ignore
Copy link
Contributor

@ashleyxuu ashleyxuu Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder what type error you get here?

Copy link
Collaborator Author

@Genesis929 Genesis929 May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the query job can return None type, which don't have .labels

@Genesis929 Genesis929 merged commit f561799 into main May 3, 2024
@Genesis929 Genesis929 deleted the labels-global-huanc branch May 3, 2024 17:25
@release-please release-please bot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast Awaiting requested review from tswast

1 more reviewer

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liujiashang liujiashang

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Genesis929 @ashleyxuu @liujiashang