Skip to content

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented Apr 8, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 329522681 🦕

@shobsi shobsi requested review from a team as code owners April 8, 2024 17:53
@shobsi shobsi requested a review from chelsea-lin April 8, 2024 17:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 8, 2024
@shobsi shobsi changed the title fix: keep most relevant dtype for aggregates test: test most relevant dtype for aggregates Apr 22, 2024
@shobsi shobsi requested a review from TrevorBergeron April 24, 2024 23:19
@shobsi shobsi merged commit 96c150a into main Apr 25, 2024
@shobsi shobsi deleted the shobs-agg-dtype branch April 25, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants