Skip to content

refactor: move remote_function logic to make a space for other types #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 1 commit into from
Jan 17, 2024
Merged

refactor: move remote_function logic to make a space for other types #322

tswast merged 1 commit into from
Jan 17, 2024

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Jan 17, 2024 •
edited
Loading

This is part of the "feature engineering of deeply nested fields" design, but could also be used for managed spark procedures and other types of BQ functions.

🦕

@tswast tswast requested review from a team as code owners January 17, 2024 16:59
@tswast tswast requested a review from ashleyxuu January 17, 2024 16:59
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 17, 2024
@tswast
Copy link
Collaborator Author

tswast commented Jan 17, 2024

Test failure: FAILED notebooks/getting_started/ml_fundamentals_bq_dataframes.ipynb appears unrelated, but I can check locally.

@tswast tswast requested a review from shobsi January 17, 2024 18:53
@tswast tswast merged commit 57bc9ab into main Jan 17, 2024
@tswast tswast deleted the tswast-refactor-functions branch January 17, 2024 20:20
@tswast tswast mentioned this pull request Jan 17, 2024
Merged
4 tasks
tswast added a commit that referenced this pull request Jan 17, 2024
@tswast
refactor: move remote_function logic to make a space for other types (#…
431a9a9 
…322) (#324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shobsi shobsi shobsi approved these changes

@ashleyxuu ashleyxuu Awaiting requested review from ashleyxuu ashleyxuu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @shobsi