Skip to content

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented Nov 29, 2023

The heads of google-cloud-bigquery and google-cloud-bigquery-storage packages are installed with -e. This is leading to from google.cloud import bigquery looking into the folder of the latter and running into "ImportError: cannot import name 'bigquery' from 'google.cloud' (.../google-cloud-bigquery-storage/google/cloud/init.py). Removing -e from google-cloud-bigquery installation gets rid of this error.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 313701211 🦕

The heads of google-cloud-bigquery and google-cloud-bigquery-storage
packages are installed with -e. This is leading to `from google.cloud
import bigquery` looking into the folder of the latter and running into
"ImportError: cannot import name 'bigquery' from 'google.cloud'
(.../google-cloud-bigquery-storage/google/cloud/__init__.py). Removing
-e from google-cloud-bigquery installation gets rid of this error.
@shobsi shobsi requested review from a team as code owners November 29, 2023 01:32
@shobsi shobsi requested a review from GarrettWu November 29, 2023 01:32
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 29, 2023
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for debugging.

@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Nov 29, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit fbc31ab into main Nov 29, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-unit-prerelease branch November 29, 2023 03:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 29, 2023
Genesis929 pushed a commit that referenced this pull request Dec 12, 2023
The heads of google-cloud-bigquery and google-cloud-bigquery-storage packages are installed with -e. This is leading to `from google.cloud import bigquery` looking into the folder of the latter and running into "ImportError: cannot import name 'bigquery' from 'google.cloud' (.../google-cloud-bigquery-storage/google/cloud/__init__.py). Removing -e from google-cloud-bigquery installation gets rid of this error.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes internal issue 313701211 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants