Skip to content

refactor: support sql_predicate when compile readtable in sqlglot #2348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chelsea-lin merged 1 commit into from
Dec 23, 2025
Merged

refactor: support sql_predicate when compile readtable in sqlglot #2348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bigframes/core/compile/sqlglot/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ def compile_readtable(node: nodes.ReadTableNode, child: ir.SQLGlotIR):
col_names=[col.source_id for col in node.scan_list.items],
alias_names=[col.id.sql for col in node.scan_list.items],
uid_gen=child.uid_gen,
sql_predicate=node.source.sql_predicate,
system_time=node.source.at_time,
)

Expand Down
6 changes: 6 additions & 0 deletions bigframes/core/compile/sqlglot/sqlglot_ir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ def from_table(
col_names: typing.Sequence[str],
alias_names: typing.Sequence[str],
uid_gen: guid.SequentialUIDGenerator,
sql_predicate: typing.Optional[str] = None,
system_time: typing.Optional[datetime.datetime] = None,
) -> SQLGlotIR:
"""Builds a SQLGlotIR expression from a BigQuery table.
Expand All @@ -131,6 +132,7 @@ def from_table(
col_names (typing.Sequence[str]): The names of the columns to select.
alias_names (typing.Sequence[str]): The aliases for the selected columns.
uid_gen (guid.SequentialUIDGenerator): A generator for unique identifiers.
sql_predicate (typing.Optional[str]): An optional SQL predicate for filtering.
system_time (typing.Optional[str]): An optional system time for time-travel queries.
"""
selections = [
Expand Down Expand Up @@ -158,6 +160,10 @@ def from_table(
version=version,
)
select_expr = sge.Select().select(*selections).from_(table_expr)
if sql_predicate:
select_expr = select_expr.where(
sg.parse_one(sql_predicate, dialect="bigquery"), append=False
)
return cls(expr=select_expr, uid_gen=uid_gen)

@classmethod
Expand Down
14 changes: 14 additions & 0 deletions ...sqlglot/snapshots/test_compile_readtable/test_compile_readtable_w_columns_filters/out.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
WITH `bfcte_0` AS (
SELECT
`int64_col`,
`rowindex`,
`string_col`
FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
WHERE
`rowindex` > 0 AND `string_col` IN ('Hello, World!')
)
SELECT
`rowindex`,
`int64_col`,
`string_col`
FROM `bfcte_0`
12 changes: 12 additions & 0 deletions tests/unit/core/compile/sqlglot/test_compile_readtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,15 @@ def test_compile_readtable_w_system_time(
)
bf_df = compiler_session.read_gbq_table(str(table_ref))
snapshot.assert_match(bf_df.sql, "out.sql")


def test_compile_readtable_w_columns_filters(compiler_session, snapshot):
columns = ["rowindex", "int64_col", "string_col"]
filters = [("rowindex", ">", 0), ("string_col", "in", ["Hello, World!"])]
bf_df = compiler_session._loader.read_gbq_table(
"bigframes-dev.sqlglot_test.scalar_types",
enable_snapshot=False,
columns=columns,
filters=filters,
)
snapshot.assert_match(bf_df.sql, "out.sql")