Skip to content

refactor: fix SQLGlot doctests on the window, ai, to_json ops #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 3 commits into from
Dec 19, 2025
Merged

refactor: fix SQLGlot doctests on the window, ai, to_json ops #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ad65b6
refactor: fix groupby.GroupBy.first doctest for sqlglot
chelsea-lin Dec 16, 2025
ed77af9
refactor: bbq.ai.generate_bool
chelsea-lin Dec 17, 2025
7c8e346
refactor: add to_json compiler
chelsea-lin Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigframes/core/compile/sqlglot/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ def compile_window(node: nodes.WindowOpNode, child: ir.SQLGlotIR) -> ir.SQLGlotI
window_op = sge.Case(ifs=when_expressions, default=window_op)

# TODO: check if we can directly window the expression.
result = child.window(
result = result.window(
window_op=window_op,
output_column_id=cdef.id.sql,
)
Expand Down
1 change: 1 addition & 0 deletions bigframes/core/compile/sqlglot/expressions/ai_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ def _construct_prompt(
for elem in prompt_context:
if elem is None:
prompt.append(exprs[column_ref_idx].expr)
column_ref_idx += 1
else:
prompt.append(sge.Literal.string(elem))

Expand Down
5 changes: 5 additions & 0 deletions bigframes/core/compile/sqlglot/expressions/json_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ def _(expr: TypedExpr) -> sge.Expression:
return sge.func("PARSE_JSON", expr.expr)


@register_unary_op(ops.ToJSON)
def _(expr: TypedExpr) -> sge.Expression:
return sge.func("TO_JSON", expr.expr)


@register_unary_op(ops.ToJSONString)
def _(expr: TypedExpr) -> sge.Expression:
return sge.func("TO_JSON_STRING", expr.expr)
Expand Down
13 changes: 13 additions & 0 deletions tests/unit/core/compile/sqlglot/expressions/snapshots/test_json_ops/test_to_json/out.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
WITH `bfcte_0` AS (
SELECT
`string_col`
FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
), `bfcte_1` AS (
SELECT
*,
TO_JSON(`string_col`) AS `bfcol_1`
FROM `bfcte_0`
)
SELECT
`bfcol_1` AS `string_col`
FROM `bfcte_1`
8 changes: 8 additions & 0 deletions tests/unit/core/compile/sqlglot/expressions/test_json_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ def test_parse_json(scalar_types_df: bpd.DataFrame, snapshot):
snapshot.assert_match(sql, "out.sql")


def test_to_json(scalar_types_df: bpd.DataFrame, snapshot):
col_name = "string_col"
bf_df = scalar_types_df[[col_name]]
sql = utils._apply_ops_to_sql(bf_df, [ops.ToJSON().as_expr(col_name)], [col_name])

snapshot.assert_match(sql, "out.sql")


def test_to_json_string(json_types_df: bpd.DataFrame, snapshot):
col_name = "json_col"
bf_df = json_types_df[[col_name]]
Expand Down
22 changes: 21 additions & 1 deletion ...mpile/sqlglot/snapshots/test_compile_window/test_compile_window_w_groupby_rolling/out.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,32 @@ WITH `bfcte_0` AS (
`int64_col` AS `bfcol_8`,
`bool_col` AS `bfcol_9`
FROM `bfcte_0`
), `bfcte_3` AS (
), `bfcte_2` AS (
SELECT
*
FROM `bfcte_1`
WHERE
NOT `bfcol_9` IS NULL
), `bfcte_3` AS (
SELECT
*,
CASE
WHEN SUM(CAST(NOT `bfcol_7` IS NULL AS INT64)) OVER (
PARTITION BY `bfcol_9`
ORDER BY `bfcol_9` ASC NULLS LAST, `rowindex` ASC NULLS LAST
ROWS BETWEEN 3 PRECEDING AND CURRENT ROW
) < 3
THEN NULL
ELSE COALESCE(
SUM(CAST(`bfcol_7` AS INT64)) OVER (
PARTITION BY `bfcol_9`
ORDER BY `bfcol_9` ASC NULLS LAST, `rowindex` ASC NULLS LAST
ROWS BETWEEN 3 PRECEDING AND CURRENT ROW
),
0
)
END AS `bfcol_15`
FROM `bfcte_2`
), `bfcte_4` AS (
SELECT
*,
Expand Down