Skip to content

refactor: Handle special float values and None consistently in sqlglot _literal #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chelsea-lin merged 3 commits into from
Dec 19, 2025
Merged

refactor: Handle special float values and None consistently in sqlglot _literal #2337

chelsea-lin merged 3 commits into from
Dec 19, 2025

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Dec 17, 2025 •
edited
Loading

This change can resolve two doctests failures in #2248: groupby.GroupBy.rank and bigframes.ml.metrics.roc_curve

Fixes internal issue 417774347🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 17, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_literal branch from 85292df to ca3023a Compare December 17, 2025 13:34
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 17, 2025
@chelsea-lin chelsea-lin marked this pull request as ready for review December 17, 2025 13:35
@chelsea-lin chelsea-lin requested review from a team as code owners December 17, 2025 13:35
@chelsea-lin chelsea-lin requested a review from jialuoo December 17, 2025 13:35
@chelsea-lin chelsea-lin requested a review from sycai December 17, 2025 13:41
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_literal branch from ca3023a to 1b28f4c Compare December 18, 2025 02:51
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_literal branch from 1b28f4c to 60d3483 Compare December 18, 2025 03:04
@chelsea-lin chelsea-lin merged commit 7d152d3 into main Dec 19, 2025
24 of 25 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_literal branch December 19, 2025 07:58
shuoweil pushed a commit that referenced this pull request Dec 19, 2025
@chelsea-lin @sycai @shuoweil
refactor: Handle special float values and None consistently in sqlglo…
81d1dbe 
…t _literal (#2337)

This change can resolve two doctests failures in #2248:
`groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve`

Fixes internal issue 417774347🦕

---------

Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sycai sycai sycai approved these changes

@jialuoo jialuoo Awaiting requested review from jialuoo jialuoo is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@TrevorBergeron TrevorBergeron

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin @sycai @TrevorBergeron