Skip to content

chore: raise error explicitly for AllOp with windows #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chelsea-lin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: raise error explicitly for AllOp with windows #2285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bea5ee
chore: raise error explicitly for AllOp with windows
chelsea-lin Nov 20, 2025
5ed6af1
apply to sqlglot compiler too
chelsea-lin Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bigframes/core/compile/ibis_compiler/aggregate_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,9 @@ def _(
column: ibis_types.Column,
window=None,
) -> ibis_types.BooleanValue:
if window is not None:
raise NotImplementedError("AllOp with windowing is not supported.")

# BQ will return null for empty column, result would be false in pandas.
result = _apply_window_if_present(_is_true(column).all(), window)
literal = ibis_types.literal(True)
Expand Down
3 changes: 3 additions & 0 deletions bigframes/core/compile/sqlglot/aggregations/unary_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ def _(
column: typed_expr.TypedExpr,
window: typing.Optional[window_spec.WindowSpec] = None,
) -> sge.Expression:
if window is not None:
raise NotImplementedError("AllOp with windowing is not supported.")

# BQ will return null for empty column, result would be false in pandas.
result = apply_window_if_present(sge.func("LOGICAL_AND", column.expr), window)
return sge.func("IFNULL", result, sge.true())
Expand Down
13 changes: 0 additions & 13 deletions ...t/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_all/window_out.sql
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions ...pile/sqlglot/aggregations/snapshots/test_unary_compiler/test_all/window_partition_out.sql
View file
Open in desktop

This file was deleted.

20 changes: 7 additions & 13 deletions tests/unit/core/compile/sqlglot/aggregations/test_unary_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,14 @@ def test_all(scalar_types_df: bpd.DataFrame, snapshot):

snapshot.assert_match(sql, "out.sql")

# Window tests
window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
sql_window = _apply_unary_window_op(bf_df, agg_expr, window, "agg_bool")
snapshot.assert_match(sql_window, "window_out.sql")

bf_df_str = scalar_types_df[[col_name, "string_col"]]
window_partition = window_spec.WindowSpec(
grouping_keys=(expression.deref("string_col"),),
ordering=(ordering.descending_over(col_name),),
)
sql_window_partition = _apply_unary_window_op(
bf_df_str, agg_expr, window_partition, "agg_bool"
)
snapshot.assert_match(sql_window_partition, "window_partition_out.sql")
def test_all_raises_error_with_window(scalar_types_df: bpd.DataFrame):
col_name = "bool_col"
bf_df = scalar_types_df[[col_name]]
agg_expr = agg_ops.AllOp().as_expr(col_name)
window = window_spec.WindowSpec(ordering=(ordering.ascending_over(col_name),))
with pytest.raises(NotImplementedError):
_apply_unary_window_op(bf_df, agg_expr, window, "agg_bool")


def test_any(scalar_types_df: bpd.DataFrame, snapshot):
Expand Down