Skip to content

feat: enable SQLGlot compiler as default #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
chelsea-lin wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: enable SQLGlot compiler as default #2248

chelsea-lin wants to merge 1 commit into from
+5 −3

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Nov 10, 2025 •
edited
Loading

Fixes internal issue 417774347🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 10, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 7a011e1 to d634b06 Compare November 11, 2025 00:22
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: l Pull request size is large. labels Nov 11, 2025
@chelsea-lin chelsea-lin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 12, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from d634b06 to c90c084 Compare November 12, 2025 20:59
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from c90c084 to eb8e92c Compare November 24, 2025 23:12
@chelsea-lin chelsea-lin mentioned this pull request Nov 25, 2025
Merged
chelsea-lin added a commit that referenced this pull request Nov 25, 2025
@chelsea-lin
refactor: switch RowNumber to 0-based indexing in sqlglot compiler (#…
3275761 
…2292)

This change aims to fix the tests failing in #2248 because of a 1-based
indexing error.

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch 2 times, most recently from 689b4e4 to 39096e5 Compare November 25, 2025 21:49
This was referenced Nov 25, 2025
Merged
Merged
chelsea-lin added a commit that referenced this pull request Nov 26, 2025
@chelsea-lin
refactor: fix ops.StrftimeOp, ops.ToDatetimeOp, ops.ToTimestampOp in …
9e0f70b 
…sqlglot compiler (#2297)

This change aims to fix the `to_datetime` related tests failing in
#2248.

Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Nov 26, 2025
@chelsea-lin
refactor: fix agg_ops.DiffOp for Datetime and Timestamp (#2296)
33a211e 
This change aims to fix the `test_timestamp_series_diff_agg` test
failing in #2248.

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin mentioned this pull request Nov 26, 2025
Merged
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 39096e5 to 2f63b1f Compare November 26, 2025 23:28
chelsea-lin added a commit that referenced this pull request Dec 1, 2025
@chelsea-lin
refactor: fix some string ops in the sqlglot compiler. (#2299)
aae1b04 
This change aims to fix some string-related tests failing in #2248.

Fixes internal issue 417774347🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 2f63b1f to 6d1b653 Compare December 15, 2025 05:52
@chelsea-lin chelsea-lin mentioned this pull request Dec 15, 2025
Merged
chelsea-lin added a commit that referenced this pull request Dec 16, 2025
@chelsea-lin
refactor: fix some string ops in the sqlglot compiler (part 2) (#2332)
0b14b17 
This change aims to fix some string-related tests failing in #2248.

Fixes internal issue 417774347🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 6d1b653 to 82ac904 Compare December 16, 2025 02:41
This was referenced Dec 17, 2025
Merged
Merged
shuoweil pushed a commit that referenced this pull request Dec 17, 2025
@chelsea-lin
refactor: fix some string ops in the sqlglot compiler (part 3) (#2336)
097fcfa 
This change aims to fix some string-related tests failing in #2248.

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin mentioned this pull request Dec 18, 2025
Merged
chelsea-lin added a commit that referenced this pull request Dec 19, 2025
@chelsea-lin @sycai
refactor: Handle special float values and None consistently in sqlglo…
7d152d3 
…t _literal (#2337)

This change can resolve two doctests failures in #2248:
`groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve`

Fixes internal issue 417774347🦕

---------

Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com>
shuoweil pushed a commit that referenced this pull request Dec 19, 2025
@chelsea-lin @sycai @shuoweil
refactor: Handle special float values and None consistently in sqlglo…
81d1dbe 
…t _literal (#2337)

This change can resolve two doctests failures in #2248:
`groupby.GroupBy.rank` and `bigframes.ml.metrics.roc_curve`

Fixes internal issue 417774347🦕

---------

Co-authored-by: Shenyang Cai <sycai@users.noreply.github.com>
tswast pushed a commit that referenced this pull request Dec 19, 2025
@chelsea-lin
refactor: fix SQLGlot doctests on the window, ai, to_json ops (#2341)
3c54c68 
This change can resolve three doctests failures in #2248: 
- Added `to_json` support to the compiler backend.
- Fixed minor bugs on AI ops
- Fixed minor bugs on windows compiler

Fixes internal issue 417774347 🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 82ac904 to 5387f52 Compare December 22, 2025 04:15
This was referenced Dec 22, 2025
Merged
Merged
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 5387f52 to 6a7dbe0 Compare December 23, 2025 01:51
chelsea-lin added a commit that referenced this pull request Dec 23, 2025
@chelsea-lin
refactor: fix group_by compiler with dtype convertions (#2350)
9674c56 
This change can resolve the `bigframes.ml.metrics.roc_auc_score`
doctests failures in #2248.

Fixes internal issue 417774347 🦕
chelsea-lin added a commit that referenced this pull request Dec 23, 2025
@chelsea-lin
refactor: support sql_predicate when compile readtable in sqlglot (#2348
b4cea76 
)

This change can resolve `read_gbq` doctests failures in #2248.

Fixes internal issue 417774347🦕
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_enablesqlglot2 branch from 6a7dbe0 to cecd9c3 Compare December 23, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chelsea-lin