Skip to content

refactor: Swap accessors from inheritance to composition #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 1 commit into from
Oct 17, 2025
Merged

refactor: Swap accessors from inheritance to composition #2177

tswast merged 1 commit into from
Oct 17, 2025

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Oct 16, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 16, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review October 16, 2025 22:41
@TrevorBergeron TrevorBergeron requested review from a team as code owners October 16, 2025 22:41
tswast
tswast approved these changes Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2025
@tswast tswast enabled auto-merge (squash) October 17, 2025 16:27
@tswast tswast merged commit fbd405d into main Oct 17, 2025
24 of 25 checks passed
@tswast tswast deleted the no_series_methods branch October 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@chelsea-lin chelsea-lin Awaiting requested review from chelsea-lin chelsea-lin is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@drylks-work drylks-work

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron @tswast @drylks-work