Skip to content

refactor: add ops.clip_op and where_op to the sqlglot compiler #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chelsea-lin merged 2 commits into from
Oct 15, 2025
Merged

refactor: add ops.clip_op and where_op to the sqlglot compiler #2168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
858df9c
refactor: add ops.where_op to the sqlglot compiler
chelsea-lin Oct 14, 2025
7781021
refactor: add ops.clip_op to the sqlglot compiler
chelsea-lin Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions bigframes/core/compile/sqlglot/expressions/generic_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import bigframes.core.compile.sqlglot.scalar_compiler as scalar_compiler

register_unary_op = scalar_compiler.scalar_op_compiler.register_unary_op
register_ternary_op = scalar_compiler.scalar_op_compiler.register_ternary_op


@register_unary_op(ops.AsTypeOp, pass_op=True)
Expand Down Expand Up @@ -66,6 +67,18 @@ def _(expr: TypedExpr, op: ops.AsTypeOp) -> sge.Expression:
return _cast(sg_expr, sg_to_type, op.safe)


@register_ternary_op(ops.clip_op)
def _(
original: TypedExpr,
lower: TypedExpr,
upper: TypedExpr,
) -> sge.Expression:
return sge.Greatest(
this=sge.Least(this=original.expr, expressions=[upper.expr]),
expressions=[lower.expr],
)


@register_unary_op(ops.hash_op)
def _(expr: TypedExpr) -> sge.Expression:
return sge.func("FARM_FINGERPRINT", expr.expr)
Expand Down Expand Up @@ -94,6 +107,13 @@ def _(expr: TypedExpr) -> sge.Expression:
return sge.Not(this=sge.Is(this=expr.expr, expression=sge.Null()))


@register_ternary_op(ops.where_op)
def _(
original: TypedExpr, condition: TypedExpr, replacement: TypedExpr
) -> sge.Expression:
return sge.If(this=condition.expr, true=original.expr, false=replacement.expr)


# Helper functions
def _cast_to_json(expr: TypedExpr, op: ops.AsTypeOp) -> sge.Expression:
from_type = expr.dtype
Expand Down
2 changes: 1 addition & 1 deletion tests/system/small/engines/test_generic_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def test_engines_astype_timedelta(scalars_array_value: array_value.ArrayValue, e
assert_equivalence_execution(arr.node, REFERENCE_ENGINE, engine)


@pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True)
@pytest.mark.parametrize("engine", ["polars", "bq", "bq-sqlglot"], indirect=True)
def test_engines_where_op(scalars_array_value: array_value.ArrayValue, engine):
arr, _ = scalars_array_value.compute_values(
[
Expand Down
15 changes: 15 additions & 0 deletions tests/unit/core/compile/sqlglot/expressions/snapshots/test_generic_ops/test_clip/out.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
WITH `bfcte_0` AS (
SELECT
`int64_col` AS `bfcol_0`,
`int64_too` AS `bfcol_1`,
`rowindex` AS `bfcol_2`
FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
), `bfcte_1` AS (
SELECT
*,
GREATEST(LEAST(`bfcol_2`, `bfcol_1`), `bfcol_0`) AS `bfcol_3`
FROM `bfcte_0`
)
SELECT
`bfcol_3` AS `result_col`
FROM `bfcte_1`
15 changes: 15 additions & 0 deletions tests/unit/core/compile/sqlglot/expressions/snapshots/test_generic_ops/test_where/out.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
WITH `bfcte_0` AS (
SELECT
`bool_col` AS `bfcol_0`,
`int64_col` AS `bfcol_1`,
`float64_col` AS `bfcol_2`
FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
), `bfcte_1` AS (
SELECT
*,
IF(`bfcol_0`, `bfcol_1`, `bfcol_2`) AS `bfcol_3`
FROM `bfcte_0`
)
SELECT
`bfcol_3` AS `result_col`
FROM `bfcte_1`
32 changes: 32 additions & 0 deletions tests/unit/core/compile/sqlglot/expressions/test_generic_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,22 @@ def test_astype_json_invalid(
)


def test_clip(scalar_types_df: bpd.DataFrame, snapshot):
op_expr = ops.clip_op.as_expr("rowindex", "int64_col", "int64_too")

array_value = scalar_types_df._block.expr
result, col_ids = array_value.compute_values([op_expr])

# Rename columns for deterministic golden SQL results.
assert len(col_ids) == 1
result = result.rename_columns({col_ids[0]: "result_col"}).select_columns(
["result_col"]
)

sql = result.session._executor.to_sql(result, enable_cache=False)
snapshot.assert_match(sql, "out.sql")


def test_hash(scalar_types_df: bpd.DataFrame, snapshot):
col_name = "string_col"
bf_df = scalar_types_df[[col_name]]
Expand Down Expand Up @@ -202,3 +218,19 @@ def test_map(scalar_types_df: bpd.DataFrame, snapshot):
)

snapshot.assert_match(sql, "out.sql")


def test_where(scalar_types_df: bpd.DataFrame, snapshot):
op_expr = ops.where_op.as_expr("int64_col", "bool_col", "float64_col")

array_value = scalar_types_df._block.expr
result, col_ids = array_value.compute_values([op_expr])

# Rename columns for deterministic golden SQL results.
assert len(col_ids) == 1
result = result.rename_columns({col_ids[0]: "result_col"}).select_columns(
["result_col"]
)

sql = result.session._executor.to_sql(result, enable_cache=False)
snapshot.assert_match(sql, "out.sql")