Skip to content

refactor: support agg_ops.RowNumberOp for sqlglot compiler #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chelsea-lin merged 1 commit into from
Sep 25, 2025
Merged

refactor: support agg_ops.RowNumberOp for sqlglot compiler #2118

chelsea-lin merged 1 commit into from
Sep 25, 2025

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Sep 25, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 25, 2025
@chelsea-lin chelsea-lin marked this pull request as ready for review September 25, 2025 22:23
@chelsea-lin chelsea-lin requested review from a team as code owners September 25, 2025 22:23
@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 25, 2025
@chelsea-lin chelsea-lin enabled auto-merge (squash) September 25, 2025 22:58
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 25, 2025
@chelsea-lin chelsea-lin merged commit 1fc563c into main Sep 25, 2025
25 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_nullary branch September 25, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees

@jialuoo jialuoo

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chelsea-lin @GarrettWu @jialuoo