refactor: add agg_ops.QuantileOp, ApproxQuartilesOp and ApproxTopCountOp to sqlglot compiler #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
chelsea-lin
force-pushed
the
main_chelsealin_quantile
branch
from
b382d3d to
5f13789
Compare
Comment on lines
247
to
249
| @property | ||
| def name(self): | ||
| return f"{self.quartile * 25}%" |
Contributor
There was a problem hiding this comment.
This might break df.agg or df.describe? MIght still use these names to create result labels. Maybe not any more though
Contributor
Author
There was a problem hiding this comment.
didn't realize the name is used for the public APIs. Just use class name for operation registration.
chelsea-lin
force-pushed
the
main_chelsealin_quantile
branch
from
5f13789 to
90c89a1
Compare
chelsea-lin
force-pushed
the
main_chelsealin_quantile
branch
from
02af3ad to
9863f29
Compare
TrevorBergeron
approved these changes
Sep 25, 2025
chelsea-lin
added
kokoro:run
bigframes-bot
removed
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 445774480 🦕