chore: Add mypy github action #1460
Conversation
product-auto-label
bot
added
size: s
TrevorBergeron
changed the title
.github/sync-repo-settings.yaml
Outdated
| - 'cla/google' | ||
| - 'docs' | ||
| - 'lint' | ||
| - 'format' |
There was a problem hiding this comment.
Do we actually want this one? As far as I know GitHub won't commit the changes back. lint also runs the formatter but will fail if any makes a change.
There was a problem hiding this comment.
I was just being conservative, and assumed that format checked things that lint didn't. So to be clear, we don't need format as a prerelease check at all?
There was a problem hiding this comment.
ok, so it looks like lint wasn't doing isort, so I integrated isort --check into the lint workflow, so no need for format
| @@ -0,0 +1,22 @@ | |||
| on: | |||
There was a problem hiding this comment.
If we add this here, I think we can safely remove from
python-bigquery-dataframes/noxfile.py
Line 119 in 7b0cab5
mypy is required check, perhaps?)
There was a problem hiding this comment.
Removing it (and others) in a following PR: #1459.
product-auto-label
bot
added
size: m
TrevorBergeron
changed the title
.github/workflows/format.yml
Outdated
There was a problem hiding this comment.
I think we can remove this file now that lint runs both black and isort.
TrevorBergeron
force-pushed
the
github_more_action
branch
from
5f39110 to
f07d4d0
Compare
product-auto-label
bot
added
size: s
3 participants
Fixes: b/401037761