Skip to content

chore: Remove most unit tests, lint, doc testing from kokoro presubmit #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrevorBergeron merged 8 commits into from
Mar 12, 2025
Merged

chore: Remove most unit tests, lint, doc testing from kokoro presubmit #1459

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc97b1f
chore: Remote most unit tests, lint, doc testing from kokoro presubmit
TrevorBergeron Mar 5, 2025
9454620
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 5, 2025
9a5adb0
Update sync-repo-settings.yaml
TrevorBergeron Mar 5, 2025
aa6c67f
support cryptograph>=3.1 (#1454)
shuoweil Mar 5, 2025
e226f5c
use presubmit config rather than nox.options.session
TrevorBergeron Mar 5, 2025
0b0d5f7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 5, 2025
f198ddf
revert to using nox.options.sessions
TrevorBergeron Mar 6, 2025
6ae15d6
Merge branch 'main' into fast_presubmits
TrevorBergeron Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,8 @@

# Sessions are executed in the order so putting the smaller sessions
# ahead to fail fast at presubmit running.
# 'docfx' is excluded since it only needs to run in 'docs-presubmit'
nox.options.sessions = [
"lint",
"lint_setup_py",
"mypy",
"format",
"docs",
"docfx",
"unit",
Copy link
Collaborator

@tswast tswast Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why keep unit but remove unit_noextras?

Edit: Oh, is it for the test coverage? Ideally we make some separate coverage targets for system vs unit tests at some point.

Copy link
Contributor Author

@TrevorBergeron TrevorBergeron Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, its for coverage, didn't want to mess too much with that, I doubt either unit, or integration tests individually would meet the coverage requirement. Maybe could just run unit tests as part of the integration suite though?

Copy link
Contributor

@shobsi shobsi Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PR#1460 we are adding back format and mypy, but what about the others?

Copy link
Contributor Author

@TrevorBergeron TrevorBergeron Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others are already covered by existing docs, unit test actions, so are already redundant

"unit_noextras",
"system-3.9",
"system-3.12",
"cover",
Expand Down