Skip to content

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Sep 16, 2021

Fixes #957.

This PR should get rid of almost all warnings when running unit tests, except from the one that seems to come from geopandas internals.

I initially read a few things on the geographic coordinate systems to understand the problem, and then tried to convert the resulting geodataframes to a different CRS. But that turned out to be a bad idea, because we actually want to actual dataframes in EPSG:4326, thus I reverted to just ignoring the user warnings in the test code.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from a team and jimfulton September 16, 2021 16:56
@plamut plamut requested a review from a team as a code owner September 16, 2021 16:56
@plamut plamut requested a review from tswast September 16, 2021 16:56
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2021
@plamut plamut merged commit 6e785c7 into googleapis:main Sep 17, 2021
@plamut plamut deleted the iss-957 branch September 17, 2021 07:51
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
…#973)

* Explicitly register custom pytest marker

* Avoid/silence user warnings in geopandas tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests emit quite a few warnings

3 participants