fix: timestamp precision in insert_rows #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
tswast
requested changes
Nov 19, 2020
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Please add a system test for this. It'll need to query the table that rows are inserted into in order to ensure the values roundtrip correctly.
Contributor
|
As my explorations showed in #392 (comment), we can format the date using |
tswast
reviewed
Nov 20, 2020
tests/unit/test__helpers.py
Outdated
|
|
||
| when = datetime.datetime(2016, 12, 20, 15, 58, 27, 339328) | ||
| self.assertEqual(self._call_fut(when), _microseconds_from_datetime(when) / 1e6) | ||
| self.assertEqual(self._call_fut(when), when.strftime(_RFC3339_MICROS)) |
Contributor
There was a problem hiding this comment.
Please update these tests to compare against the actual string produced. I trust that when.strftime(_RFC3339_MICROS) is doing the right thing, but I'd be much more comfortable seeing the actual formatted string here and in the other unit tests.
tswast
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392