Skip to content

refactor(bigquery): update code samples of load table autodetect and truncate #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HemangChothani merged 9 commits into from
May 13, 2020
Merged

refactor(bigquery): update code samples of load table autodetect and truncate #28

HemangChothani merged 9 commits into from
May 13, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Feb 6, 2020

Move the snippets to their own sample files

List of changes:

  1. load_table_uri_autodetect_csv
  2. load_table_uri_autodetect_json
  3. load_table_uri_truncate_avro.py
  4. load_table_uri_truncate_json.py
  5. load_table_uri_truncate_csv.py
  6. load_table_uri_truncate_orc.py
  7. load_table_uri_truncate_parquet.py

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2020
@HemangChothani HemangChothani force-pushed the bigquery_update_load_table_autodetect_truncate_code_sample branch from 471439d to a1bcbce Compare February 6, 2020 13:05
@plamut plamut mentioned this pull request Feb 10, 2020
Closed
plamut
plamut approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast requested review from shollyman and removed request for tswast March 3, 2020 17:10
@plamut
Copy link
Contributor

plamut commented Mar 26, 2020

@shollyman Do you have anything to add here?

plamut and others added 2 commits April 7, 2020 12:46
@HemangChothani
Copy link
Contributor Author

HemangChothani commented Apr 29, 2020

@shollyman PTAL!

@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2020
@HemangChothani
Merge branch 'master' of https://github.com/googleapis/python-bigquery …
4143c63 
…into bigquery_update_load_table_autodetect_truncate_code_sample
@HemangChothani
Merge branch 'master' of https://github.com/googleapis/python-bigquery …
1167f54 
…into bigquery_update_load_table_autodetect_truncate_code_sample
@HemangChothani
Copy link
Contributor Author

HemangChothani commented May 11, 2020

@shollyman Friendly ping. :)

shollyman
shollyman approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and being patient with a terribly slow reviewer.

@HemangChothani HemangChothani merged commit 18eb9e8 into googleapis:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

+1 more reviewer

@plamut plamut plamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HemangChothani @plamut @shollyman @googlebot @yoshi-kokoro