test: check extreme DATE/DATETIME values can be loaded from pandas DataFrame #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
tseaver
approved these changes
Dec 1, 2021
| # TODO: Support writing StructArrays to Parquet. See: | ||
| # https://jira.apache.org/jira/browse/ARROW-2587 | ||
| # bigquery.SchemaField("struct_col", "RECORD", fields=scalars_schema), | ||
| ) |
Contributor
There was a problem hiding this comment.
Are we just bailing on those two TODO entries?
Contributor
Author
There was a problem hiding this comment.
These tests are actually already covered in the v3 branch.
python-bigquery/tests/system/test_pandas.py
Line 294 in 3b3ebff
Contributor
Where's that issue, is this a typo? Edit: Ah, the original issue has been transferred, will update the PR description. |
plamut
approved these changes
Dec 2, 2021
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
Looks good, assuming that simply removing those TODOs is indeed intended.
| # TODO: Support writing StructArrays to Parquet. See: | ||
| # https://jira.apache.org/jira/browse/ARROW-2587 | ||
| # bigquery.SchemaField("struct_col", "RECORD", fields=scalars_schema), | ||
| ) |
tswast
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
…taFrame (googleapis#1078) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Towards #1076 🦕 (edit: moved to googleapis/python-db-dtypes-pandas#45 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #1076 🦕
(edit: moved to googleapis/python-db-dtypes-pandas#45 )