Skip to content

chore: clean up HAS_GRPC_GCP #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vchudnov-g merged 1 commit into from
Feb 10, 2026
Merged

chore: clean up HAS_GRPC_GCP #892

vchudnov-g merged 1 commit into from
Feb 10, 2026
+36 −100

Conversation

@vchudnov-g
Copy link
Contributor

@vchudnov-g vchudnov-g commented Feb 10, 2026

No description provided.

@vchudnov-g vchudnov-g requested a review from a team as a code owner February 10, 2026 19:40
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 10, 2026
@gemini-code-assist
Copy link

gemini-code-assist bot commented Feb 10, 2026

Summary of Changes

Hello @vchudnov-g, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the test suite for gRPC channel creation by eliminating redundant conditional checks related to the HAS_GRPC_GCP flag. The changes simplify the test logic and remove a specific test case that is no longer necessary, contributing to a cleaner and more maintainable codebase for gRPC helper functions.

Highlights

  • Test Simplification: Removed conditional logic based on grpc_helpers.HAS_GRPC_GCP from multiple test cases in test_grpc_helpers.py, streamlining the test assertions for grpc_secure_channel calls.
  • Test Case Removal: Deleted the test_create_channel_with_grpc_gcp test function, as its conditional execution based on HAS_GRPC_GCP is no longer relevant.
  • Skip Condition Update: Adjusted the @pytest.mark.skipif decorator for test_create_channel_without_grpc_gcp to reflect the removal of the HAS_GRPC_GCP check.
Changelog
  • tests/unit/test_grpc_helpers.py
    • Removed conditional HAS_GRPC_GCP checks from test_create_channel_implicit, test_create_channel_implicit_with_default_host, test_create_channel_implicit_with_ssl_creds, test_create_channel_implicit_with_scopes, test_create_channel_implicit_with_default_scopes, test_create_channel_explicit, test_create_channel_explicit_scoped, test_create_channel_explicit_default_scopes, test_create_channel_explicit_with_quota_project, test_create_channel_with_credentials_file, test_create_channel_with_credentials_file_and_scopes, and test_create_channel_with_credentials_file_and_default_scopes.
    • Deleted the test_create_channel_with_grpc_gcp test function.
    • Modified the @pytest.mark.skipif decorator for test_create_channel_without_grpc_gcp.
Activity
  • No specific activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@vchudnov-g vchudnov-g mentioned this pull request Feb 10, 2026
Merged
@vchudnov-g
Copy link
Contributor Author

vchudnov-g commented Feb 10, 2026

This is in response to a previous PR's comment

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 10, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively cleans up test code related to HAS_GRPC_GCP. Since grpc_helpers.HAS_GRPC_GCP is consistently False, the conditional logic and a test case that would always be skipped have been removed. This improves the maintainability and clarity of the test suite by removing dead code and unnecessary complexity.

@vchudnov-g vchudnov-g merged commit bfc6651 into main Feb 10, 2026
19 checks passed
@vchudnov-g vchudnov-g deleted the py-drop-3-cleanup branch February 10, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Linchin Linchin

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vchudnov-g @parthea @Linchin