Skip to content

Conversation

@rinarakaki
Copy link
Contributor

@rinarakaki rinarakaki commented Oct 11, 2024

Enables googleapis/python-cloud-core#302

I checked:

  • pyright google/api_core/client_options.py

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakaki rinarakaki requested review from a team as code owners October 11, 2024 09:09
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 11, 2024
@rinarakaki rinarakaki changed the title add typing chore: add typing Oct 11, 2024
@rinarakaki rinarakaki changed the title chore: add typing fix: add type hints to ClientOption Oct 12, 2024
@parthea parthea changed the title fix: add type hints to ClientOption fix: add type hints to ClientOptions Oct 19, 2024
@parthea
Copy link
Collaborator

parthea commented Oct 19, 2024

Thanks @rinarakaki !

@parthea parthea merged commit b91ed19 into googleapis:main Oct 19, 2024
This was referenced May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants