Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

ci: update test configuration #129

Merged
parthea merged 18 commits into from
Oct 5, 2021
Merged

ci: update test configuration #129

parthea merged 18 commits into from
Oct 5, 2021

Conversation

@ikuleshov
Copy link
Contributor

@ikuleshov ikuleshov commented Sep 2, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ikuleshov ikuleshov requested a review from a team as a code owner September 2, 2021 00:52
@ikuleshov ikuleshov requested a review from crwilcox September 2, 2021 00:52
@product-auto-label product-auto-label bot added the api: analyticsadmin Issues related to the googleapis/python-analytics-admin API. label Sep 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2021
@ikuleshov ikuleshov marked this pull request as draft September 2, 2021 00:53
@ikuleshov ikuleshov changed the title update test configuration fix: update test configuration Sep 2, 2021
@ikuleshov ikuleshov requested review from parthea and removed request for crwilcox September 2, 2021 00:55
@ikuleshov ikuleshov mentioned this pull request Sep 2, 2021
Closed
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@parthea parthea changed the title fix: update test configuration ci: update test configuration Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 2, 2021
@google-cla
Copy link

google-cla bot commented Sep 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 2, 2021
@google-cla
Copy link

google-cla bot commented Sep 2, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@nicain nicain mentioned this pull request Sep 2, 2021
Merged
@parthea
Copy link
Contributor

parthea commented Sep 30, 2021

@ikuleshov Friendly ping

This was referenced Sep 30, 2021
Merged
Merged
@ikuleshov ikuleshov added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@ikuleshov ikuleshov added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@ikuleshov ikuleshov added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 5, 2021
@ikuleshov ikuleshov added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@ikuleshov
Merge remote-tracking branch 'upstream/main'
a3e4f17
@ikuleshov
Merge remote-tracking branch 'origin/master'
7de1885 
# Conflicts:
#	samples/noxfile.py
@ikuleshov
delete enhanced measurement settings samples as this functionality is…
a88d15e 
… no longer supported in v1alpha
@ikuleshov
fix the samples tests
e76ba96
@ikuleshov
do not use the maximum_user_access field and update operation in …
3836b72 
…properties.firebase_links tests as this is no longer supported in v1alpha
@ikuleshov
use creator_email_address instead of email_address field in prope…
d235358 
…rties.google_ads_links_list() test as the field has been renamed in v1alpha
@snippet-bot
Copy link

snippet-bot bot commented Oct 5, 2021

Here is the summary of changes.

You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ikuleshov ikuleshov marked this pull request as ready for review October 5, 2021 09:32
@ikuleshov
Copy link
Contributor Author

ikuleshov commented Oct 5, 2021

@parthea Looks like all tests are passing now!

parthea
parthea approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ikuleshov !

@parthea parthea merged commit f5790a9 into googleapis:main Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@parthea parthea parthea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: analyticsadmin Issues related to the googleapis/python-analytics-admin API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikuleshov @parthea @yoshi-kokoro