Fix to build HttpResponseException when charset is malformed #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tentCharset() if charset is malformed
googlebot
added
the
cla: yes
chingor13
requested changes
Dec 10, 2018
Contributor
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Can we add a test case for this?
google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@chingor13 added test case. please take a look. |
chingor13
approved these changes
Dec 11, 2018
This was referenced Jan 3, 2019
yoshi-automation
added a commit
that referenced
this pull request
May 11, 2020
Source-Author: Stephanie Wang <stephaniewang526@users.noreply.github.com> Source-Date: Mon May 11 16:24:04 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 98c50772ec23295c64cf0d2ddf199ea52961fd4c Source-Link: googleapis/synthtool@98c5077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #323 IllegalCharsetNameException in HttpResponse getContentCharset() if charset is malformed