Repository navigation
ci: testing bad behavior change #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
56077c6
12c631d
706abed
6750e91
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| on: | ||
| # This should run for only pull requests for this repository's LTS branches | ||
| pull_request: | ||
| branches: | ||
| - '*-sp' | ||
| name: LTS Library Test | ||
| jobs: | ||
| lts-library-test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| # Only the downstream of this libraries are needed | ||
| repository: | ||
| - beam | ||
| # - google-api-java-client This does not work for LTS BOM Test due to bintray decommission | ||
| - google-auth-library-java | ||
| - google-maps-services-java | ||
| - grpc-java | ||
| - java-bigquery | ||
| - java-bigtable-hbase | ||
| - java-monitoring | ||
| - java-pubsub | ||
| - java-spanner | ||
| - java-storage | ||
| - java-trace | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-java@v1 | ||
| with: | ||
| java-version: 8 | ||
| - id: find_library_version | ||
| name: Find the library version in this branch | ||
| run: | | ||
| sudo apt-get install libxml2-utils | ||
| VERSION=`sed -e 's/xmlns="[^\s\\]*"//' pom.xml | xmllint --xpath '/project/version/text()' -` | ||
| echo "::set-output name=version::${VERSION}" | ||
| - name: Install this repository's artifacts to local Maven repository | ||
| run: | | ||
| mvn --batch-mode --show-version --no-transfer-progress install \ | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it possible to specify some strange version number (that would not conflict) when installing this artifact?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does |
||
| -DskipTests=true \ | ||
| -Dclirr.skip=true \ | ||
| -Denforcer.skip=true \ | ||
| -Dmaven.javadoc.skip=true \ | ||
| -Dgcloud.download.skip=true | ||
| # The lts_tests branch has not merged to master but it hosts GitHub Actions. | ||
| - uses: GoogleCloudPlatform/cloud-opensource-java/lts-test@lts_tests | ||
| with: | ||
| repository: ${{ matrix.repository }} | ||
| version_override_key: http.version | ||
| version_override_value: ${{ steps.find_library_version.outputs.version }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -876,7 +876,7 @@ public HttpResponse execute() throws IOException { | |
| executeException = null; | ||
|
|
||
| // run the interceptor | ||
| if (executeInterceptor != null) { | ||
| if (executeInterceptor == null) { // This code is wrong. Just for testing. | ||
| executeInterceptor.intercept(this); | ||
|
Comment on lines
+879
to
880
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. However, this approach does not work for Gradle projects such as "LTS Library Test / lts-library-test (beam)". |
||
| } | ||
| // build low-level HTTP request | ||
|
|
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elharo (a followup from yesterday's discussion) This command extracts the version from the root pom.xml. This configuration file no longer needs to specify a hard-coded version. The value is then used at the end of this file as
version_override_valueparameter.(I tweaked the command from https://github.com/googleapis/java-cloud-bom/blob/8a45813a6590d3a25dcaad4fa5d6beaeb341b3d3/.kokoro/bom-upper-bounds-check.sh#L43)
This sed+xmllint approach should work for Yoshi repositories. Other projects, such as grpc-java and Beam, will have other regular expression to extract their versions.