Repository navigation
Conversation
| if (executeInterceptor == null) { // This code is wrong. Just for testing. | ||
| executeInterceptor.intercept(this); |
There was a problem hiding this comment.
However, this approach does not work for Gradle projects such as "LTS Library Test / lts-library-test (beam)".
| with: | ||
| repository: ${{ matrix.repository }} | ||
| version_override_key: http.version | ||
| version_override_value: 1.39.2 |
There was a problem hiding this comment.
This should not be manually set.
| java-version: 8 | ||
| - name: Install this repository's artifacts to local Maven repository | ||
| run: | | ||
| mvn --batch-mode --show-version --no-transfer-progress install \ |
There was a problem hiding this comment.
Is it possible to specify some strange version number (that would not conflict) when installing this artifact?
There was a problem hiding this comment.
Does {x-version-update:google-http-client-parent:current} help?
|
Why does "LTS Library Test / lts-library-test (beam)" succeed? Experiment 1In the install_lts-library-check_bad-change branch of google-http-java-client, update the version to 1.39.2-sp.2 Then update the Install the BOM to local Maven repository. Running the test with the modification fails the Beam test as expected. Good. Experiment 2What if we don't change the version? Google-http-client 1.39.2 is in Maven already. In the install_lts-library-check_bad-change branch of google-http-java-client, keeping the version 1.39.2, I installed it to local Maven repository. I installed the LTS BOM to local Maven repository. Then I ran the test again It passed. Bad. From this experiment, the artifacts stored in local Maven repository have lower priority than the artifacts in Maven central (or Gradle cache?). |
|
Maybe the Gradle is not reading the local Maven repository first? |
|
Version Some of the configuration files were not updated by |
b89e3a8 to
8c0db1c
Compare
828daed to
6406919
Compare
6406919 to
6750e91
Compare
| - id: find_library_version | ||
| name: Find the library version in this branch | ||
| run: | | ||
| sudo apt-get install libxml2-utils | ||
| VERSION=`sed -e 's/xmlns="[^\s\\]*"//' pom.xml | xmllint --xpath '/project/version/text()' -` | ||
| echo "::set-output name=version::${VERSION}" |
There was a problem hiding this comment.
@elharo (a followup from yesterday's discussion) This command extracts the version from the root pom.xml. This configuration file no longer needs to specify a hard-coded version. The value is then used at the end of this file as version_override_value parameter.
(I tweaked the command from https://github.com/googleapis/java-cloud-bom/blob/8a45813a6590d3a25dcaad4fa5d6beaeb341b3d3/.kokoro/bom-upper-bounds-check.sh#L43)
This sed+xmllint approach should work for Yoshi repositories. Other projects, such as grpc-java and Beam, will have other regular expression to extract their versions.
|
can this be closed now? |
|
Yes. Closing. Thank you for followup. |


No need to review.
This PR contains a behavior change that would break other libraries.