feat(bigquery): add create job method #9882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
HemangChothani
changed the title
tswast
reviewed
Dec 4, 2019
| job_config (dict): configuration job representation returned from the API. | ||
| Keyword Arguments: | ||
| source (Union[ \ |
Contributor
There was a problem hiding this comment.
These arguments are quite odd to be including in a generic "create job" function.
Better to add the needed properties to the relevant -JobConfig classes.
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
Unit test is failing which is unrelated to these changes. I think it's related to PR 9915. |
Contributor
Author
|
@tswast PTAL! |
Contributor
Author
|
Suppressed by googleapis/python-bigquery#32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9781