tests(vision): normalize VPCSC configuration in systests #9620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use 'vpcsc_config' test utility for parsing VPCSC env vars, skipping. - Use idiomatic 'with pytest.raises' for blocked methods. - Avoid calling 'unique_id()' more than once. - Remove test for VPCSC of storage client.
googlebot
added
the
cla: yes
10 tasks
busunkim96
approved these changes
Nov 7, 2019
brendanlundy
reviewed
Nov 9, 2019
Per request from @brendanlundy: #9620 (comment)
crwilcox
pushed a commit
to googleapis/python-vision
that referenced
this pull request
Feb 1, 2020
* tests(vision): normalize VPCSC configuration in systests - Use 'vpcsc_config' test utility for parsing VPCSC env vars, skipping. - Use idiomatic 'with pytest.raises' for blocked methods. - Avoid calling 'unique_id()' more than once. - Remove test for VPCSC of storage client. * fix: blacken * fix: lint * fix: update partial error message Per request from @brendanlundy: googleapis/google-cloud-python#9620 (comment)
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* tests(vision): normalize VPCSC configuration in systests - Use 'vpcsc_config' test utility for parsing VPCSC env vars, skipping. - Use idiomatic 'with pytest.raises' for blocked methods. - Avoid calling 'unique_id()' more than once. - Remove test for VPCSC of storage client. * fix: blacken * fix: lint * fix: update partial error message Per request from @brendanlundy: #9620 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #7580.