Fixes #937 - Adds HTTP method and URL to exceptions. #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
googlebot
added
the
cla: no
Addressing comments in review and tox failures.
Contributor
Author
|
@tseaver PTAL The things left unaddressed from the last PR were as follows: From
From @dhermes: Should we have a newline somewhere in the error message if it gets too long? (I lean towards no because of line wrapping.) |
Contributor
|
I'm -0 on injecting a newline (thinking e.g. about logfiles: human readability vs. parsing by machine). |
Contributor
Author
|
WDYT of |
Contributor
|
I've closed #938 |
Contributor
Author
|
@tseaver Are we all good then? |
Contributor
|
LGTM |
Contributor
|
LGTM - sorry for letting this linger. Thanks for cleaning it up for me :( |
Contributor
Author
|
No worries @jgeewax |
dhermes
added a commit
that referenced
this pull request
Jul 3, 2015
Fixes #937 - Adds HTTP method and URL to exceptions.
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
* doc: add samples for filtering using async apis * format * suffix snippets
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* feat: support query profiling * collection * fix unit tests * unit tests * vector get and stream, unit tests * aggregation get and stream, unit tests * docstring * query profile unit tests * update base classes' method signature * documentsnapshotlist unit tests * func signatures * undo client.py change * transaction.get() * lint * system test * fix shim test * fix sys test * fix sys test * system test * another system test * skip system test in emulator * stream generator unit tests * coverage * add system tests * small fixes * undo document change * add system tests * vector query system tests * format * fix system test * comments * add system tests * improve stream generator * type checking * adding stars * delete comment * remove coverage requirements for type checking part * add explain_options to StreamGenerator * yield tuple instead * raise exception when explain_metrics is absent * refactor documentsnapshotlist into queryresultslist * add comment * improve type hint * lint * move QueryResultsList to stream_generator.py * aggregation related type annotation * transaction return type hint * refactor QueryResultsList * change stream generator to return ExplainMetrics instead of yield * update aggregation query to use the new generator * update query to use the new generator * update vector query to use the new generator * lint * type annotations * fix type annotation to be python 3.9 compatible * fix type hint for python 3.8 * fix system test * add test coverage * use class method get_explain_metrics() instead of property explain_metrics * feat: add explain_metrics to async generator * async support for query * system tests for query * query profile for async vector query * vector query system test * async transaction * async transaction system test * async collection * fix system test * test coverage * test coverage * collection system test * async aggregation * lint * cover * lint * aggregation system tests * cover and fix system test * delete type ignore * improve type annotation * mypy * mypy * address comments * delete comments * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jgeewax Taking #938 over since it lingered.
@tseaver I rebased and will shortly send another commit addressing review feedback.