Skip to content

fix(monitoring): make VPCSC env comparison case-insensitive #9564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 5 commits into from
Nov 6, 2019
Merged

fix(monitoring): make VPCSC env comparison case-insensitive #9564

tseaver merged 5 commits into from
Nov 6, 2019

Conversation

@steinwaywhw
Copy link
Contributor

@steinwaywhw steinwaywhw commented Oct 29, 2019

The actual environment variable value may be True, instead of true. So just make it case insensitive.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
@tseaver tseaver changed the title Make VPCSC env comparison case-insensitive. fix(monitoring): make VPCSC env comparison case-insensitive Oct 29, 2019
tseaver
tseaver suggested changes Oct 29, 2019
View reviewed changes
@tseaver tseaver mentioned this pull request Oct 29, 2019
Closed
2 tasks
@steinwaywhw @tseaver
Update monitoring/noxfile.py
cee06dc 
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@googlebot
Copy link

googlebot commented Oct 31, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 31, 2019
@steinwaywhw @tseaver
Update monitoring/noxfile.py
649a9b8 
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@steinwaywhw
Copy link
Contributor Author

steinwaywhw commented Oct 31, 2019

@googlebot I fixed it.

@steinwaywhw
Copy link
Contributor Author

steinwaywhw commented Nov 4, 2019 •
edited
Loading

Hi @tseaver, please sign CLA using your personal email. See link above, or equivalently this one

@tseaver
Copy link
Contributor

tseaver commented Nov 5, 2019

@googlebot I consent.

@tseaver
Copy link
Contributor

tseaver commented Nov 5, 2019

@steinwaywhw I made those edits through the web: the e-mail associated with them (tseaver@palladion.com) is my normal one.

@googlebot
Copy link

googlebot commented Nov 6, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 6, 2019
steinwaywhw
steinwaywhw commented Nov 6, 2019
View reviewed changes
Copy link
Contributor Author

@steinwaywhw steinwaywhw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark suggested edits as resolved.

@tseaver tseaver merged commit 7a3a74d into googleapis:master Nov 6, 2019
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@steinwaywhw @tseaver
fix(monitoring): make VPCSC env comparison case-insensitive (#9564)
f4af0d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steinwaywhw @googlebot @tseaver