Skip to content

feat(cloudbuild): generate v1 #9510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
busunkim96 merged 12 commits into from
Nov 7, 2019
Merged

feat(cloudbuild): generate v1 #9510

busunkim96 merged 12 commits into from
Nov 7, 2019

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Oct 21, 2019 •
edited
Loading

I named the directory cloudbuild rather than build.

The generator names the package google-cloud-cloudbuild, but I'd be open to naming it google-cloud-build. Thoughts?

Product team said they preferred google-cloud-build, so I've added a synth replace.

TODO:

  • Setup Kokoro configs internally
  • Add Kokoro config in GitHub

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2019
@busunkim96 busunkim96 marked this pull request as ready for review October 23, 2019 17:55
@busunkim96 busunkim96 mentioned this pull request Oct 23, 2019
Merged
tseaver
tseaver suggested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other library (containeranalysis) which uses google/cloud/devtools doesn't declare it as a namespace package, which means that installing it won't be compatible with this one if we continue to ship the library this PR generates.

busunkim96
busunkim96 commented Oct 24, 2019
View reviewed changes
Copy link
Contributor Author

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think google/cloud/ is the only namespace package for both?

google/cloud/__init__.py (namespace package):

google/cloud/devtools/__init__.py (regular package):

@tseaver
Copy link
Contributor

tseaver commented Oct 25, 2019

@busunkim96 Try installing google-cloud-containeranalysis and the new google-cloud-build library in the same virtualenv: the fact that google.cloud.devtools is not declared by both as a namespace package means that one of the two won't be importable (or maybe the second install will fail, depending on pip's behavior).

@busunkim96
Copy link
Contributor Author

busunkim96 commented Oct 31, 2019

@tseaver Ah I see. So my options are:

  1. change containeranalysis and cloudbuild to both declare google.cloud.devtools as a namespace package.
  2. place cloudbuild in google.cloud.cloudbuild

I'll probably do 1, and note in the README that you need google-cloud-containeranalysis>=x.x.x to be able to install side by side with google-cloud-build.

@busunkim96 busunkim96 mentioned this pull request Nov 5, 2019
Merged
@busunkim96 busunkim96 requested a review from tseaver November 6, 2019 23:19
@busunkim96 busunkim96 merged commit 8c83b52 into googleapis:master Nov 7, 2019
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
feat(cloudbuild): generate v1 (#9510)
2ace4a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@busunkim96 @tseaver @plamut @googlebot