fix(automl): pass credentials to underlying clients in TableClient #9491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
In automl_v1beta1.TablesClient.__init__(), the credentials are not given to AutoMlClient and PredictionServiceClient, causing inconsistency between the credentials that was passed and the credentials that was actually used for API calls. This commit ensures that credentials are passed, and add two unittests to catch the behavior. Fixes googleapis#9490
shunghsiyu
force-pushed
the
automl_table_client_credentials_fix
branch
from
60676df to
a6a2d05
Compare
Contributor
Author
|
I'm not sure what is the best way to implements the tests, as the two test cases are actually quite similar. Open to suggestions and edits. |
busunkim96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sirtorry
approved these changes
Oct 18, 2019
busunkim96
approved these changes
Oct 28, 2019
This was referenced Oct 29, 2019
Closed
Closed
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…9491) In automl_v1beta1.TablesClient.__init__(), the credentials are not given to AutoMlClient and PredictionServiceClient, causing inconsistency between the credentials that was passed and the credentials that was actually used for API calls. This commit ensures that credentials are passed, and add two unittests to catch the behavior. Fixes #9490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In automl_v1beta1.TablesClient.init(), the credentials are not given to AutoMlClient and PredictionServiceClient, causing inconsistency between the credentials that was passed and the credentials that was actually used for API calls.
This commit ensures that credentials are passed, and add two unittests to catch the behavior.
Fixes #9490