Fake commit. #942
Closed
Fake commit. #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
added
the
do not merge
googlebot
added
the
cla: yes
dhermes
force-pushed
the
fake-commit-test-coveralls
branch
from
f4e5d16 to
a66b43d
Compare
Contributor
|
LOL: failed lint:
|
Contributor
Author
|
@tseaver Yep and I also discovered |
Contributor
Author
Contributor
Author
|
@tseaver I signed in to coveralls.io and changed the settings, let's hope this handles it
|
Contributor
Author
|
I should mention that both the "COVERAGE THRESHOLD FOR FAILURE" and "COVERAGE DECREASE THRESHOLD FOR FAILURE" boxes were empty (which I take to mean unset) before I updated the values. |
Contributor
Author
|
@tseaver I'm closing out. It looks like tweaking the settings did the trick. Feel free to re-open if you don't think this resolves it. |
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tseaver This is to make sure #940 works.