Fixes #937 - Adds HTTP method and URL to exceptions. #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Let's not let this thing linger. Merge or close. |
This was referenced Jun 25, 2015
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
* chore(main): release 0.29.2 * Update CHANGELOG.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* feat: support query profiling * collection * fix unit tests * unit tests * vector get and stream, unit tests * aggregation get and stream, unit tests * docstring * query profile unit tests * update base classes' method signature * documentsnapshotlist unit tests * func signatures * undo client.py change * transaction.get() * lint * system test * fix shim test * fix sys test * fix sys test * system test * another system test * skip system test in emulator * stream generator unit tests * coverage * add system tests * small fixes * undo document change * add system tests * vector query system tests * format * fix system test * comments * add system tests * improve stream generator * type checking * adding stars * delete comment * remove coverage requirements for type checking part * add explain_options to StreamGenerator * yield tuple instead * raise exception when explain_metrics is absent * refactor documentsnapshotlist into queryresultslist * add comment * improve type hint * lint * move QueryResultsList to stream_generator.py * aggregation related type annotation * transaction return type hint * refactor QueryResultsList * change stream generator to return ExplainMetrics instead of yield * update aggregation query to use the new generator * update query to use the new generator * update vector query to use the new generator * lint * type annotations * fix type annotation to be python 3.9 compatible * fix type hint for python 3.8 * fix system test * add test coverage * use class method get_explain_metrics() instead of property explain_metrics * address comments * remove more Optional * add type hint for async stream generator * simplify yield in aggregation stream * stream generator type annotation * more type hints * remove "Integer" * docstring format * mypy * add more input verification for query_results.py
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Old:
gcloud.exceptions.NotFound: 404 Resource not found (resource=new).New:
gcloud.exceptions.NotFound: 404 Resource not found (resource=new). (DELETE https://pubsub.googleapis.com/v1beta2/projects/jjg-cloud-research/topics/new)Wasn't sure about a couple things, so wanted to ask...
request_string). Seems expressive, but would rather pass a request object or something similar. Should I rename? Or pass two (methodandurl) on tomake_exception?make_exceptioncall (seemed like it might be better done on a separate line?)