Adding the ability to set Subscription path #919

philibuster · 2015-06-08T23:16:39Z

A user should be able to set the path of the subscription, so it isn't always set to the topics project.

This allow users to subscribe to topics in other projects (if they have edit rights to said project).

googlebot · 2015-06-08T23:16:40Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

googlebot · 2015-06-08T23:26:21Z

CLAs look good, thanks!

dhermes · 2015-06-09T04:14:48Z

@philibuster Can you give some sample code using this or some description of why you'd want to be able to change the project on the fly.

This change is a little too ad-hoc for the object model, but that doesn't mean we can't take the spirit of the change and turn it into something useful.

A subscription has 4 properties

name
topic
ack_deadline
push_endpoint

and you could accomplish essentially what you want with

topic1 = Topic(name, project=project1)
topic2 = Topic(name, project=project2)

subscription1 = Subscription(sub_name, topic1, ack_deadline=AD, push_endpoint=PE)
subscription2 = Subscription(sub_name, topic2, ack_deadline=AD, push_endpoint=PE)

but it could be more convenient to have something which preserved all properties except for the topic via:

subscription2 = Subscription.copy_from(subscription1, topic=topic2)

Even more, you want the same topic name, but just a different project, so this still isn't quite the same.

philibuster · 2015-06-09T09:48:08Z

Thank you for the response. Sorry I made a mistake in my code, what I originally wrote would have no value.

Example:
There are two projects:

project1 with one topic "topic1"
project2 with no topics (it doesnt matter)

As project2 I want to make a subscription to the other projects topic.
If I made a subscription it will try use the first project. projects/project1/subscriptions/sub with project/project1/topics/topic1
But I want projects/project2/subscriptions/sub with project/project1/topics/topic1

What I am proposing is using any project in the subscription path. It still will only work if they are allowed access to create the subscription anyway.

dhermes · 2015-06-17T23:57:09Z

I see. So my proposal would need to be tweaked to something like

>>> topic = Topic(name, project=project1)
>>> subscription = Subscription(sub_name, topic, ack_deadline=AD, push_endpoint=PE)
>>> # New code
>>> subscription2 = Subscription.copy_from(subscription1, project=project2)
>>> subscription.topic.name == subscription2.topic.name
True
>>> subscription.topic is subscription2.topic
False
>>> subscription.topic.project == subscription2.topic.project
False

PS @philibuster Sorry for getting behind on this.

philibuster · 2015-06-18T14:32:12Z

@dhermes No problem :)

Not exactly, the topic should not be changed, just the subscription path

>>> subscription.topic == subscription2.topic
True
>>> subscription.path == subscription2.path
False

dhermes · 2015-06-18T16:24:30Z

@philibuster That breaks the model, which is why I was offering the alternative.

As of right now (June 18), the hierarchy is

client -> topic -> subscription

and a client has a fixed project, which both the topic and subscription can reference and use.

dhermes · 2015-06-24T02:12:26Z

@philibuster WDYT of the proposed given my comment?

I want to keep this moving (either to close it out or to get to something we can agree on implementing).

dhermes · 2015-07-02T16:39:51Z

@philibuster I'd love to take this up, let's re-open if you get some bandwidth to keep the discussion moving forward.

philibuster · 2015-07-05T19:13:14Z

@dhermes Sorry about the delay.

Yeah all for a copy_from method, maybe similar to modify_push_configuration. I think it'd be a useful method (at least to me and those that work with me), as it'd allow subscribing to other projects topics.

* test: make pyarrow sample less flaky * add comment

🤖 I have created a release \*beep\* \*boop\* --- ## [0.49.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.48.1...v0.49.0) (2021-06-11) ### Features * add async samples ([#861](https://www.github.com/googleapis/gapic-generator-python/issues/861)) ([e385ffd](https://www.github.com/googleapis/gapic-generator-python/commit/e385ffd7f012c6a38c9fcd7c5f36ce090311032b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* feat: Expose the `FindNearest.distance_result_field` parameter feat: Expose the `FindNearest.distance_threshold` parameter PiperOrigin-RevId: 660557033 Source-Link: googleapis/googleapis@28685f7 Source-Link: googleapis/googleapis-gen@38f25b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzhmMjViMGJjZjU0NjEzNzU4ZWQ1NWE2MzkwYmM4NGU0MDM2OGRjMiJ9 chore: Update gapic-generator-python to v1.18.4 PiperOrigin-RevId: 657207628 Source-Link: googleapis/googleapis@33fe71e Source-Link: googleapis/googleapis-gen@e02739d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTAyNzM5ZDEyMmVkMTViZDVlZjU3NzFjNTdmMTJhODNkNDdhMWRkYSJ9 chore: Update gapic-generator-python to v1.18.3 PiperOrigin-RevId: 656040068 Source-Link: googleapis/googleapis@3f4e29a Source-Link: googleapis/googleapis-gen@b8feb21 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjhmZWIyMTA5ZGRlN2IwOTM4YzIyYzk5M2QwMDIyNTFhYzY3MTRkYyJ9 chore: Update gapic-generator-python to v1.18.3 PiperOrigin-RevId: 655567917 Source-Link: googleapis/googleapis@43aa65e Source-Link: googleapis/googleapis-gen@0e38378 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGUzODM3ODc1MzA3NGMwZjY2ZmY2MzM0OGQ2ODY0OTI5ZTEwNGQ1YyJ9 chore: expose new experimental FindNearest distance params to the preview branch docs: minor documentation clarifications on FindNearest DistanceMeasure options PiperOrigin-RevId: 655267922 Source-Link: googleapis/googleapis@7858db4 Source-Link: googleapis/googleapis-gen@c075428 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzA3NTQyODJlODA2MjU2NTk1OWI1MjM5MWJiM2FkZGI4NzAyNjdiOCJ9 feat(spanner): Add support for Cloud Spanner Scheduled Backups PiperOrigin-RevId: 649277844 Source-Link: googleapis/googleapis@fd7efa2 Source-Link: googleapis/googleapis-gen@50be251 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTBiZTI1MTMyOWQ4ZGI1YjU1NTYyNmViZDQ4ODY3MjFmNTQ3ZDNjYyJ9 feat: add bulk delete api docs: update field api description PiperOrigin-RevId: 642337904 Source-Link: googleapis/googleapis@9aab32e Source-Link: googleapis/googleapis-gen@757cf9d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzU3Y2Y5ZDhlMmQxMzlkN2IyODcxY2UwMTNkNWUyZWRjNDAxNzZkMyJ9 chore: Update gapic-generator-python to v1.18.0 PiperOrigin-RevId: 638650618 Source-Link: googleapis/googleapis@6330f03 Source-Link: googleapis/googleapis-gen@44fa4f1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9 chore: Update gapic-generator-python to v1.17.1 PiperOrigin-RevId: 629071173 Source-Link: googleapis/googleapis@4afa392 Source-Link: googleapis/googleapis-gen@16dbbb4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZkYmJiNGQwNDU3ZGI1ZTYxYWM5Zjk5YjBkNTJhNDYxNTQ0NTVhYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.18.5 PiperOrigin-RevId: 661268868 Source-Link: googleapis/googleapis@f7d214c Source-Link: googleapis/googleapis-gen@79a8411 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzlhODQxMWJiZGIyNWE5ODNmYTNhYWU4YzBlMTQzMjdkZjEyOWY5NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

)

Test types under CI using new 'mypy' nox session. Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 8, 2015

philibuster force-pushed the add-setter-to-subscription-path branch from 076b491 to 3567321 Compare June 8, 2015 23:26

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 8, 2015

philibuster force-pushed the add-setter-to-subscription-path branch 3 times, most recently from 8aecf6a to cd8460a Compare June 8, 2015 23:40

Adding the ability to set Subscription path

3121e40

philibuster force-pushed the add-setter-to-subscription-path branch from cd8460a to 3121e40 Compare June 8, 2015 23:50

philibuster force-pushed the add-setter-to-subscription-path branch from 659e5e7 to 3121e40 Compare June 10, 2015 19:49

pep8 fixes, and tests changes, adding attribute _path

70d9787

philibuster force-pushed the add-setter-to-subscription-path branch from 18c04af to 70d9787 Compare June 10, 2015 22:41

dhermes mentioned this pull request Jun 25, 2015

Adding Pylint plugin to check Sphinx docstrings. #948

Merged

dhermes closed this Jul 2, 2015

parthea pushed a commit that referenced this pull request Aug 21, 2025

test: make pyarrow sample less flaky (#919)

ceda3d8

* test: make pyarrow sample less flaky * add comment

parthea pushed a commit that referenced this pull request Sep 16, 2025

test: make pyarrow sample less flaky (#919)

2d730db

* test: make pyarrow sample less flaky * add comment

parthea pushed a commit that referenced this pull request Nov 24, 2025

docs(__init__): Note that Firestore in Datastore Mode is supported (#919

c055f04

)

parthea pushed a commit that referenced this pull request Nov 26, 2025

feat: add 'py.typed' declaration (#919)

1e4a8e1

Test types under CI using new 'mypy' nox session. Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding the ability to set Subscription path #919

Adding the ability to set Subscription path #919

Uh oh!

philibuster commented Jun 8, 2015

Uh oh!

googlebot commented Jun 8, 2015

Uh oh!

googlebot commented Jun 8, 2015

Uh oh!

dhermes commented Jun 9, 2015

Uh oh!

philibuster commented Jun 9, 2015

Uh oh!

dhermes commented Jun 17, 2015

Uh oh!

philibuster commented Jun 18, 2015

Uh oh!

dhermes commented Jun 18, 2015

Uh oh!

dhermes commented Jun 24, 2015

Uh oh!

dhermes commented Jul 2, 2015

Uh oh!

philibuster commented Jul 5, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Adding the ability to set Subscription path #919

Adding the ability to set Subscription path #919

Uh oh!

Conversation

philibuster commented Jun 8, 2015

Uh oh!

googlebot commented Jun 8, 2015

Uh oh!

googlebot commented Jun 8, 2015

Uh oh!

dhermes commented Jun 9, 2015

Uh oh!

philibuster commented Jun 9, 2015

Uh oh!

dhermes commented Jun 17, 2015

Uh oh!

philibuster commented Jun 18, 2015

Uh oh!

dhermes commented Jun 18, 2015

Uh oh!

dhermes commented Jun 24, 2015

Uh oh!

dhermes commented Jul 2, 2015

Uh oh!

philibuster commented Jul 5, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants