Skip to content

Conversation

@pradn
Copy link
Contributor

@pradn pradn commented Aug 29, 2019

Closes #8990

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2019
@busunkim96 busunkim96 added the api: pubsub Issues related to the Pub/Sub API. label Aug 29, 2019
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes should be re-arranged, and the release level needs to be set to ga in .repo-metadata.json.

If you are already working on this after submitting a PR, please consider the remark irrelevant, will wait for the new set of changes.

@pradn
Copy link
Contributor Author

pradn commented Aug 29, 2019

Release notes should be re-arranged, and the release level needs to be set to ga in .repo-metadata.json.

If you are already working on this after submitting a PR, please consider the remark irrelevant, will wait for the new set of changes.

Okay, done.

Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we have now covered all items from the ticket description, and addressed all the comments on the PR. 🎉

Approving.

@plamut plamut merged commit 9240062 into googleapis:master Aug 29, 2019
@yoshi-automation
Copy link
Contributor

@yoshi-automation
Copy link
Contributor

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor

🥚 You hatched a release! The release build finished successfully! 💜

emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
* Release 1.0.0

* Update CPS Python library READMEs to indicate the library is now GA. Also add some extra notes about versioning and contributions.

* Fix badge image

* Fix rst docs

* Address comments by Peter and Bu Sun

* Update repo metadata

* Improve changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PubSub: Release the first GA version

5 participants