Skip to content

Conversation

@pradn
Copy link
Contributor

@pradn pradn commented Aug 29, 2019

…Also add some extra notes about versioning and contributions.

Closes #8990

…Also add some extra notes about versioning and contributions.
@pradn pradn requested a review from plamut August 29, 2019 15:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2019
@plamut plamut added the api: pubsub Issues related to the Pub/Sub API. label Aug 29, 2019
@plamut plamut changed the title Update CPS Python library READMEs to indicate the library is now GA. … PubSub: Update CPS Python library READMEs to indicate the library is now GA. Aug 29, 2019
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image icon is still beta (line 22 in pubsub/README.rst)

And the CONTRIBUTING link might be missing the target, if I read the markdown correctly.

@plamut plamut added type: docs Improvement to the documentation for an API. needs work This is a pull request that needs a little love. labels Aug 29, 2019
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links should use the Sphinx markdown to render correctly, please fix.

Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in README files LGTM now. 👍

@plamut plamut removed the needs work This is a pull request that needs a little love. label Aug 29, 2019
@busunkim96
Copy link
Contributor

Could you also change the release level to ga in the .repo-metadata.json?

"release_level": "beta",

@tseaver
Copy link
Contributor

tseaver commented Aug 29, 2019

These changes should normally be part of the PR which makes the actual google-cloud-pubsub 1.0.0 release (see #9140 for an example).

@plamut
Copy link
Contributor

plamut commented Aug 29, 2019

@busunkim96 Is that necessary in this PR, or is this done by the releasetool?

(there will be another PR following this one)

Edit: Ok, @tres already explained, should be a single PR.

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 29, 2019
@busunkim96
Copy link
Contributor

@plamut Releasetool doesn't do that automatically right now. I'll add a TODO to add that.

I agree with @tseaver. It'd be nicer for these changes to be made in the release PR.

@plamut
Copy link
Contributor

plamut commented Aug 29, 2019

@busunkim96 On it, will follow up with an autogenerated PR shortly.

I will also add a note to update repo metadata to the ticket description.

@plamut plamut closed this Aug 29, 2019
@pradn
Copy link
Contributor Author

pradn commented Aug 29, 2019

Closing in favor of #9145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PubSub: Release the first GA version

5 participants