-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PubSub: Update CPS Python library READMEs to indicate the library is now GA. #9144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Also add some extra notes about versioning and contributions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image icon is still beta (line 22 in pubsub/README.rst)
And the CONTRIBUTING link might be missing the target, if I read the markdown correctly.
plamut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links should use the Sphinx markdown to render correctly, please fix.
plamut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in README files LGTM now. 👍
|
Could you also change the release level to
|
|
These changes should normally be part of the PR which makes the actual |
|
@busunkim96 Is that necessary in this PR, or is this done by the releasetool? (there will be another PR following this one) Edit: Ok, @tres already explained, should be a single PR. |
|
@busunkim96 On it, will follow up with an autogenerated PR shortly. I will also add a note to update repo metadata to the ticket description. |
|
Closing in favor of #9145 |
…Also add some extra notes about versioning and contributions.
Closes #8990