BigQuery Storage: Replace obsolete test helper method #9090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autodetected schema assumes NULLABLE fields, thus use NULLABLE columns in test fixture.
The _add_rows() helper function is no longer needed, since client.load_table_from_json() essentially does the same.
plamut
added
the
api: bigquerystorage
googlebot
added
the
cla: yes
plamut
added
needs work
plamut
force-pushed
the
sys-tests-refactor
branch
2 times, most recently
from
f673429 to
2f70d23
Compare
plamut
force-pushed
the
sys-tests-refactor
branch
from
2f70d23 to
05867e8
Compare
tswast
approved these changes
Aug 28, 2019
Contributor
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Thanks for the clean-up PR. Just one update, then we can merge.
tswast
approved these changes
Aug 28, 2019
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
* Make all system tests table columns NULL-able Autodetected schema assumes NULLABLE fields, thus use NULLABLE columns in test fixture. * Replace helper function with BQ client method The _add_rows() helper function is no longer needed, since client.load_table_from_json() essentially does the same. * Use explicit schema in data types decoding test * Adjust a comment related to partial schemas
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
* Make all system tests table columns NULL-able Autodetected schema assumes NULLABLE fields, thus use NULLABLE columns in test fixture. * Replace helper function with BQ client method The _add_rows() helper function is no longer needed, since client.load_table_from_json() essentially does the same. * Use explicit schema in data types decoding test * Adjust a comment related to partial schemas
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Make all system tests table columns NULL-able Autodetected schema assumes NULLABLE fields, thus use NULLABLE columns in test fixture. * Replace helper function with BQ client method The _add_rows() helper function is no longer needed, since client.load_table_from_json() essentially does the same. * Use explicit schema in data types decoding test * Adjust a comment related to partial schemas
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
* Make all system tests table columns NULL-able Autodetected schema assumes NULLABLE fields, thus use NULLABLE columns in test fixture. * Replace helper function with BQ client method The _add_rows() helper function is no longer needed, since client.load_table_from_json() essentially does the same. * Use explicit schema in data types decoding test * Adjust a comment related to partial schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #8992 (comment). It replaces the system tests helper method
_add_rows()with a very similar method from BigQuery client.