Remove 'Bucket.iter' and 'Bucket.contains'. #877

tseaver · 2015-05-13T20:55:49Z

Both are "sugar" over other methods, but do not allow passing an explicit connection.

In addition, Bucket.__iter__ has scaling issues, which cannot be mitigated using the filtering parameters accepted by Bucket.list_blobs.

Moved to a new PR from #876.

dhermes · 2015-05-13T21:07:13Z

Big time test failure here. Do you know why?

tseaver · 2015-05-14T14:21:03Z

I ran the tests in a different shell, which I closed accidentally before committing. :(

I will rebase / fix after merging #876.

tseaver · 2015-05-14T16:21:43Z

@dhermes rebased.

gcloud/storage/bucket.py

dhermes · 2015-05-14T17:41:01Z

So the reason I asked you to peel this off from #876 was really so we could discuss if this should happen.

I have never really liked the methods, but some may like them. So let's discuss?

tseaver · 2015-05-14T17:49:55Z

To clarify what we are discussiing: first, we are removing:

if blob_name in bucket:
   do_something()

which is a syntactic alias for:

blob = Blob(blob_name, bucket)
if blob.exists():
    do_something()

Note that do_something() likely needs to construct the Blob anyway, which makes the second a lot more natural. The second form also allows us to override the connection used by the exists() call, if desired.

Second, we are removing:

for blob in bucket:
    do_something(blob)

which is a syntactic alias for:

for blob in bucket.list_blobs():
    do_something(blob)

Here, the list_blobs() form allows us to override the connection used, if desired, as well as providing filtering parameters to minimize the set of returned blobs: the latter could be crucial for dealing with very large buckets.

Both are 'sugar' over other methods, but do not allow passing an explicit connection. In addition, 'Bucket.__iter__' has scaling issues, which cannot be mitigated using the filtering parameters accepted by 'Bucket.list_blobs'.

dhermes · 2015-05-14T18:20:51Z

@jgeewax Are you OK with us removing this?

I am on-board with this change.

jgeewax · 2015-05-14T18:25:18Z

I'm down with removing the methods, but we need to update the docs in the same PR, right? (https://googlecloudplatform.github.io/gcloud-python/latest/storage-buckets.html refers to for blob in bucket and print 'blob' in bucket.)

dhermes · 2015-05-14T18:27:13Z

+1

tseaver · 2015-05-14T19:28:07Z

@jgeewax 3a3edb4 removes the docstring examples which referred to the sugar.

…nd___contains__ Remove 'Bucket.__iter__' and 'Bucket.__contains__'.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Tim Sweña (Swast) <swast@google.com>

Source-Link: googleapis/synthtool@d52e638 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [click](https://palletsprojects.com/p/click/) ([changelog](https://click.palletsprojects.com/changes/)) | `==7.1.2` -> `==8.0.0` | [![age](https://badges.renovateapi.com/packages/pypi/click/8.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/click/8.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/click/8.0.0/compatibility-slim/7.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/click/8.0.0/confidence-slim/7.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-python).

* chore(deps): update all dependencies * pin importlib-resources for python 3.7 * revert urllib3 --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

… in Cloud Run Jobs (#877) * fix: Added environment specific labels to client library when running in Cloud Run Jobs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Removed unnecessary import * Changed unit tests to pytest * Renamed add_environmental_labels to add_resource_labels; cached portions of add_resource_labels * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Updated comments and _get_environmental_labels * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

While service account impersonation is uncommonly used with workforce pool external credentials, there is a bug where the following commands raise exceptions when impersonated workforce pools are used: - `google.auth.default()` - `google.auth.load_credentials_from_file()` The issue is due to `google.auth.aws.Credentials` not supporting the `workforce_pool_user_project` argument in the constructor, unlike `google.auth.identity_pool.Credentials`. This was indirectly passed here: https://github.com/googleapis/google-auth-library-python/blob/a37ff00d7afd6c7aac2d0fab29e05708bbc068be/google/auth/external_account.py#L395 Causing a TypeError to be raised (we only catch ValueError). Updated the credential determination logic to explicitly check the subject token type. This is a more reliable indicator instead of a try/catch. Increased unit test coverage in tests/test__default.py to cover these credentials.

tseaver added the api: storage Issues related to the Cloud Storage API. label May 13, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2015

tseaver mentioned this pull request May 13, 2015

Remove 'Bucket.connection' property #876

Merged

dhermes reviewed May 14, 2015
View reviewed changes

gcloud/storage/bucket.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added the type: question Request for information or clarification. Not an issue. label May 14, 2015

Remove 'Bucket.__iter__' and 'Bucket.__contains__'.

32526bf

Both are 'sugar' over other methods, but do not allow passing an explicit connection. In addition, 'Bucket.__iter__' has scaling issues, which cannot be mitigated using the filtering parameters accepted by 'Bucket.list_blobs'.

Catch up docstrings w/ removed '__iter__'/'__contains__'.

3a3edb4

tseaver added a commit that referenced this pull request May 14, 2015

Merge pull request #877 from tseaver/storage-remove_bucket___iter___a…

fd73bcf

…nd___contains__ Remove 'Bucket.__iter__' and 'Bucket.__contains__'.

tseaver merged commit fd73bcf into googleapis:master May 14, 2015

tseaver deleted the storage-remove_bucket___iter___and___contains__ branch May 14, 2015 20:11

dhermes mentioned this pull request Jun 4, 2015

Upgrading version to 0.6.0. #907

Merged

parthea pushed a commit that referenced this pull request Sep 18, 2025

chore(main): release 0.27.0 (#877)

b351ede

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Tim Sweña (Swast) <swast@google.com>

parthea added a commit that referenced this pull request Nov 24, 2025

chore(deps): update all dependencies (#877)

d2a538a

* chore(deps): update all dependencies * pin importlib-resources for python 3.7 * revert urllib3 --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove 'Bucket.iter' and 'Bucket.contains'. #877

Remove 'Bucket.iter' and 'Bucket.contains'. #877

Uh oh!

tseaver commented May 13, 2015

Uh oh!

dhermes commented May 13, 2015

Uh oh!

tseaver commented May 14, 2015

Uh oh!

tseaver commented May 14, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 14, 2015

Uh oh!

tseaver commented May 14, 2015

Uh oh!

dhermes commented May 14, 2015

Uh oh!

jgeewax commented May 14, 2015

Uh oh!

dhermes commented May 14, 2015

Uh oh!

tseaver commented May 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove 'Bucket.__iter__' and 'Bucket.__contains__'. #877

Remove 'Bucket.__iter__' and 'Bucket.__contains__'. #877

Uh oh!

Conversation

tseaver commented May 13, 2015

Uh oh!

dhermes commented May 13, 2015

Uh oh!

tseaver commented May 14, 2015

Uh oh!

tseaver commented May 14, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 14, 2015

Uh oh!

tseaver commented May 14, 2015

Uh oh!

dhermes commented May 14, 2015

Uh oh!

jgeewax commented May 14, 2015

Uh oh!

dhermes commented May 14, 2015

Uh oh!

tseaver commented May 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Remove 'Bucket.iter' and 'Bucket.contains'. #877

Remove 'Bucket.iter' and 'Bucket.contains'. #877