Monitoring: Update noxfile.py #8295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT` should be a project outside of the VPCSC perimeter. `PROJECT_ID` is a project inside the perimeter. Do not uncomment until we have a project for the second environment variable. Otherwise this wrong value is breaking the system tests of the VPCSC team.
googlebot
added
the
cla: yes
Contributor
|
Hi @steinwaywhw, I think this was my mistake when I set the environment variables. Would a setup like this result in the tests running correctly? PROJECT_OUTISDE -> the default project we use for tests in this repo (outside the perimeter) |
busunkim96
added
api: monitoring
Contributor
Author
|
Hi @busunkim96 no worries. Yes, your suggested value for the environment variables would work. |
Contributor
|
Superseded by #8302. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECTshould be a project outside of the VPCSC perimeter.PROJECT_IDis a project inside the perimeter. Do not uncomment until we have a project for the second environment variable. Otherwise this wrong value is breaking the system tests of the VPCSC team.