-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added more expressive module docstring to batch.py #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like lint is failing... but not saying why. Running pylint says the line is too long... Any ideas how I could make the line shorter without cutting the hyperlink? @tseaver |
|
@jgeewax Pylint only allows hyperlinks > 80 characters if they are standalone on the line. E.g., https://github.com/GoogleCloudPlatform/gcloud-python/blob/6283ab9c9d7fa06f6800079bd882b573c4de7cf7/gcloud/pubsub/api.py#L28 |
|
Also the link has 84 chars, 8 of which are |
|
Changes Unknown when pulling e765268 on jgeewax:master into * on GoogleCloudPlatform:master*. |
|
Assigning to @tseaver for review |
gcloud/datastore/batch.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling 283217a on jgeewax:master into * on GoogleCloudPlatform:master*. |
|
LGTM |
Added more expressive module docstring to batch.py
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update samples/snippets/requirements.txt --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* feat: add DeleteDatabase API and delete protection docs: update Database API description PiperOrigin-RevId: 591922567 Source-Link: googleapis/googleapis@204f2ae Source-Link: googleapis/googleapis-gen@bd98650 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmQ5ODY1MDAwMzUwNDY1MjcxOTExZDk5Njg5Yjc1NjExNTg4NTVkNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add new types QueryMode, QueryPlan, ResultSetStats feat: add QueryMode field to RunQueryRequest feat: add ResultSetStats field to RunQueryResponse feat: add QueryMode field to RunAggregationQueryRequest feat: add ResultSetStats field to RunAggregationQueryResponse PiperOrigin-RevId: 595771083 Source-Link: googleapis/googleapis@2027807 Source-Link: googleapis/googleapis-gen@5407e2b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTQwN2UyYjY4NjM5MjhjMjZmNTJkYjlmMzQ3YzZiNTU1NmU3MDJmMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: Fix formatting due to unclosed backtick PiperOrigin-RevId: 597942027 Source-Link: googleapis/googleapis@6c31cc0 Source-Link: googleapis/googleapis-gen@4a99b8d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGE5OWI4ZGM5MDEzNmQzZjI5Y2NmNDBmN2Q5ZGVhM2I2ZjI2ZGJiOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Daniel Sanche <sanche@google.com>
Cloud NDB is one of the final Cloud Client libraries to support Python 2 and retaining support for it will prevent us from updating to the newest version of the underlying Datastore libraries. Not considering this a breaking change because pip will respect python_requires in setup.py and not install a version that doesn't support it anymore.
* feat: add api key support * chore: update * Update google/auth/_default.py Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [2.4.0](googleapis/google-auth-library-python@v2.3.3...v2.4.0) (2022-01-20) ### Features * add 'py.typed' declaration ([#919](googleapis/google-auth-library-python#919)) ([c993504](googleapis/google-auth-library-python@c993504)) * add api key support ([#826](googleapis/google-auth-library-python#826)) ([3b15092](googleapis/google-auth-library-python@3b15092)) ### Bug Fixes * **deps:** allow cachetools 5.0 for python 3.7+ ([#937](googleapis/google-auth-library-python#937)) ([1eae37d](googleapis/google-auth-library-python@1eae37d)) * fix the message format for metadata server exception ([#916](googleapis/google-auth-library-python#916)) ([e756f08](googleapis/google-auth-library-python@e756f08)) ### Documentation * fix intersphinx link for 'requests-oauthlib' ([#921](googleapis/google-auth-library-python#921)) ([967be4f](googleapis/google-auth-library-python@967be4f)) * note ValueError in `verify_oauth2_token` ([#928](googleapis/google-auth-library-python#928)) ([82bc5f0](googleapis/google-auth-library-python@82bc5f0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.