Skip to content

Conversation

@crwilcox
Copy link
Contributor

This pull request was generated using releasetool.

@crwilcox crwilcox requested a review from theacodes as a code owner March 12, 2019 19:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2019
@tseaver
Copy link
Contributor

tseaver commented Mar 12, 2019

I thought you were going to hold off until we got the Firestore gRPC header fix in place.

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 12, 2019
@crwilcox
Copy link
Contributor Author

@tseaver, I am looking into that now, but because that likely means modifying the interface to bidi to support an additional argument, I figured that would trigger a minor release. This I can do as a patch which will be picked up by all clients since we don't pin to patch release.

@crwilcox crwilcox merged commit aea0a99 into master Mar 13, 2019
@yoshi-automation
Copy link
Contributor

@yoshi-automation
Copy link
Contributor

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor

🥚 You hatched a release! The release build finished successfully! 💜

@tseaver tseaver deleted the release-api_core-1.8.1 branch May 24, 2019 17:44
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants