Skip to content

Firestore: remove bogus error checking of query response stream. #7206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Jan 28, 2019
Merged

Firestore: remove bogus error checking of query response stream. #7206

tseaver merged 1 commit into from
Jan 28, 2019

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 23, 2019

Closes #6924.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Jan 23, 2019
@tseaver tseaver requested review from crwilcox and mcdonc January 23, 2019 19:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2019
@tseaver tseaver mentioned this pull request Jan 23, 2019
Closed
@tseaver tseaver merged commit e79dfde into googleapis:master Jan 28, 2019
@tseaver tseaver deleted the 6924-firestore-query_response_skip_empty branch January 28, 2019 18:03
@tseaver tseaver mentioned this pull request Apr 23, 2019
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tseaver
Remove bogus error checking of query response stream. (#7206)
9d59c0f 
Closes #6924.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcdonc mcdonc Awaiting requested review from mcdonc

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees

No one assigned

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tseaver @googlebot