-
Notifications
You must be signed in to change notification settings - Fork 1.6k
STORAGE: Making Connection.get_all_buckets a standalone method. #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STORAGE: Making Connection.get_all_buckets a standalone method. #716
Conversation
See comments in googleapis#700 for context.
9c78309 to
4f0c483
Compare
|
LGTM. I would just move |
|
Cool. I'll wait on Travis before merging. We've also got a 3 PR backup in the "merged" queue: |
|
Changes Unknown when pulling 4f0c483 on dhermes:storage-move-get-all-buckets-to-api into * on GoogleCloudPlatform:master*. |
STORAGE: Making Connection.get_all_buckets a standalone method.
…716) Source-Link: googleapis/synthtool@280ddae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:346ab2efb51649c5dde7756cbbdc60dd394852ba83b9bbffc292a63549f33c17 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* fix: updating testing, rest-only generation, & minor bug-fixes * test: test async client generation * fix: fixed reserved keyword bug, fixed bugs in gapic tests * fix: reverted bug causing change to , refactored template tests * fix: return type mismatch * fix: reserved keyword issue in * fix: replace bad regex checks with checks against field_pb type * Update gapic/templates/noxfile.py.j2 Co-authored-by: Dov Shlachter <dovs@google.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
* feat: Replace utcnow and utcfromtimestamp These will be deprecated starting in Python 3.12. Replaced: - `datetime.datetime.utcnow()` with `datetime.datetime.now(tz=datetime.timezone.utc)` - `datetime.utcfromtimestamp()` with `datetime.fromtimestamp(tz=datetime.timezone.utc)` * docs: deprecate google.cloud.firestore_v1.rate_limiter.utcnow * remove usage of google.cloud.firestore_v1.rate_limiter.utcnow in code * filter deprecation warning for google.cloud.firestore_v1.rate_limiter.utcnow --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>
See comments in #700 for context.
@tseaver I figured it would be easier to digest moving one method at a time instead of all 4 at once. Still remaining:
NOTE: I re-ran the storage demo to make sure this worked and noticed the very first line was the license. Without the opening
the demo is pretty tough to use. I can add the license back at the end of the file if necessary or even after
# Welcome ...(/cc @jgeewax).