Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 19, 2015

NOTE: Has #665 as a diffbase

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 15db084 on dhermes:lazy-loading-attempt-3 into 72b6359 on GoogleCloudPlatform:master.

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Feb 19, 2015
@dhermes dhermes mentioned this pull request Feb 19, 2015
@tseaver
Copy link
Contributor

tseaver commented Feb 19, 2015

15db084 LGTM

@dhermes dhermes force-pushed the lazy-loading-attempt-3 branch from 15db084 to 7d75636 Compare February 19, 2015 19:36
@dhermes
Copy link
Contributor Author

dhermes commented Feb 19, 2015

Rebased on top of #665. Had to sniff out the redundant tests since the test moved wholesale.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7d75636 on dhermes:lazy-loading-attempt-3 into 6ff634a on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Feb 19, 2015
Moving set_default_dataset_id into _implicit_environ.
@dhermes dhermes merged commit 26dba83 into googleapis:master Feb 19, 2015
@dhermes dhermes deleted the lazy-loading-attempt-3 branch February 19, 2015 19:39
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 22, 2025
* chore(deps): update all dependencies

* revert

* increase timeouts

* increase timeouts

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Features in the Ads templates require Python 3.7 or later.
parthea added a commit that referenced this pull request Nov 24, 2025
* feat: optimize _GapicCallable

* cleaned up metadata lines

* chore: avoid type checks in error wrapper

* Revert "chore: avoid type checks in error wrapper"

This reverts commit c97a6365028f3f04d20f26aa1cc0e3131164f53e.

* add default wrapped function

* fixed decorator order

* fixed spacing

* fixed comment typo

* fixed spacing

* fixed spacing

* removed unneeded helpers

* use caching

* improved metadata parsing

* improved docstring

* fixed logic

* added benchmark test

* update threshold

* run benchmark in loop for testing

* use verbose logs

* Revert testing

* used smaller value

* changed threshold

* removed link in comment

* use list type for metadata

* add types to docstring

* fixed lint

* convert to list at init time

---------

Co-authored-by: Daniel Sanche <sanche@google.com>
Co-authored-by: Daniel Sanche <d.sanche14@gmail.com>
parthea added a commit that referenced this pull request Nov 24, 2025
This reverts commit 169511959497bd4509305c5424532e817c6a9cb2.
parthea pushed a commit that referenced this pull request Nov 24, 2025
In Cloud Datastore ancestor queries are intended to be strong by default
(https://cloud.google.com/datastore/docs/concepts/structuring_for_strong_consistency) .

In Cloud Firestore in Datastore mode, all queries should be strongly
consistent by default (https://cloud.google.com/datastore/docs/upgrade-to-firestore).

Fixes #666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants