-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Move the 'thread-local stack' implementation up from datastore. #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the 'thread-local stack' implementation up from datastore. #622
Conversation
Preparing to tackle #15, which needs similar support in storage.
gcloud/_localstack.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM (I think you should clarify the module docstring, but do as you see fit). |
|
@tseaver When merged can you ping me and point at the next PR in line? |
|
I'm still working on the next-in-line (it is the real meat of #15). |
See: #622 (comment). [ci skip].
Move the 'thread-local stack' implementation up from datastore.
|
OK cool |
|
Just took a peek. I feel like the multipart stuff will have been handled already by @craigcitro Also, what sorts of API requests are allowed with batch? Any and all? |
|
I didn't see any of that in Batching can handle |
|
writing from my phone - but apitools has full batch support. see base/py/batch.py |
|
I didn't see the batching support in @craigcitro It looks like the |
|
|
|
@tseaver ah, i probably don't export |
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Don't bump protobuf yet, it's not compatible Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com>
Google Cloud defines a small set of common resources that do not belong to specific APIs or message types. All generated service clients now contain helper methods that allow construction and parsing of these paths. See https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto for the list of common resources for Google Cloud.
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9
Preparing to tackle #15, which needs similar support in storage.