Skip to content

Release bigquery 1.5.0 #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 1 commit into from
Aug 2, 2018
Merged

Release bigquery 1.5.0 #5735

tswast merged 1 commit into from
Aug 2, 2018

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Aug 2, 2018 •
edited
Loading

This pull request was generated using releasetool.

Closes #5726

@tswast tswast requested a review from alixhami as a code owner August 2, 2018 18:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2018
@tswast tswast requested a review from tseaver August 2, 2018 18:17
@tswast tswast merged commit 9b85429 into master Aug 2, 2018
@tseaver
Copy link
Contributor

tseaver commented Aug 2, 2018

@tswast I don't see the bigquery-1.5.0 tag, nor an entry on the release page.

@tseaver tseaver deleted the release-bigquery-1.5.0 branch August 2, 2018 20:18
@tseaver
Copy link
Contributor

tseaver commented Aug 2, 2018

Note that the PyPI release won't be done by CI without making / pushing the tag.

@tswast
Copy link
Contributor Author

tswast commented Aug 2, 2018

That's because the test hadn't finished running yet. It just failed. :-( https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/7549

Assigning to @crwilcox to cut the release manually.

@tseaver
Copy link
Contributor

tseaver commented Aug 2, 2018

@tswast That CI run was against master (following the merge of this PR). We also need to get a tag made and pushed, which will kick of another CI run for the tag: that one will publish the release to PyPI (if it succeeds). We also need to create a Github release from the tag, and copy over the 1.5.0 changelog to it.

@tswast
Copy link
Contributor Author

tswast commented Aug 2, 2018

Release is at https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/bigquery-1.5.0

@tswast
Copy link
Contributor Author

tswast commented Aug 2, 2018

Thanks. I forgot to run "releasetool tag". Just tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alixhami alixhami alixhami approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast @tseaver @alixhami @googlebot