Skip to content

make dependency on logging less restrictive in error_reporting #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 2 commits into from
May 18, 2018
Merged

make dependency on logging less restrictive in error_reporting #5345

tseaver merged 2 commits into from
May 18, 2018

Conversation

@tcwalther
Copy link
Contributor

@tcwalther tcwalther commented May 18, 2018

This PR makes the dependency on google-cloud-python less restrictive in google-cloud-error-reporting. Currently, it is not possible to install google-cloud-error-reporting alongside other up-to-date google-cloud-python packages.

Of course, there may be great reasons why it was so restrictive in the first place, in which case I'd love for the author to explain the cause.

If this change is fine, it would be great if this was merged swiftly and published to PyPI with an updated version number.

@tcwalther tcwalther requested a review from waprin as a code owner May 18, 2018 13:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2018
@tseaver tseaver added packaging api: clouderrorreporting Issues related to the Error Reporting API. labels May 18, 2018
@tseaver
Copy link
Contributor

tseaver commented May 18, 2018 •
edited
Loading

@theacodes ISTM that with logging at > 1.0, we could amend the logging pin to >=1.4.0, < 2.0dev without risk.

@theacodes
Copy link
Contributor

theacodes commented May 18, 2018

Yeah go for that. I seem to remember us wanting to just absorb error reporting into logging.

@googlebot
Copy link

googlebot commented May 18, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 18, 2018
@tseaver tseaver merged commit b7b8444 into googleapis:master May 18, 2018
@tseaver tseaver mentioned this pull request May 18, 2018
Closed
@tcwalther tcwalther deleted the error-reporting-less-restrictive-logging-dependency branch May 19, 2018 13:18
@tcwalther
Copy link
Contributor Author

tcwalther commented May 19, 2018

This has already been merged, but just for completeness: I hereby to confirm that I am happy for this altered commit to be merged.

Would be fantastic to see a new version being pushed to PyPI :-).

parthea pushed a commit that referenced this pull request Nov 24, 2025
@tcwalther @tseaver
Make dependency on logging less restrictive in error_reporting (#5345)
82009bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waprin waprin Awaiting requested review from waprin

Assignees

No one assigned

Labels

api: clouderrorreporting Issues related to the Error Reporting API. cla: no This human has *not* signed the Contributor License Agreement. packaging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tcwalther @tseaver @theacodes @googlebot