futures now install_requires - #4991
Conversation
According to pypa/pipenv#1547 (comment) the current extras_require format to specify platform dependencies is deprecated, so moving it upwards Also look here:http://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-platform-specific-dependencies
googlebot
added
the
cla: yes
|
Interesting. I'll need to do some testing to make sure this doesn't break in some older toolchains, but thank you for bringing this to our attention! |
|
Thanks. |
|
Here’s how Pytest makes sure about the environment marker support level, for the most paranoid: https://github.com/pytest-dev/pytest/blob/6553468/setup.py#L26 In general most packages shouldn’t worry about this, unless with good reasons (I can imagine Google Cloud Platform being one of them). Keeping unnecessary support to the old syntax gives users incentive to use outdated versions of Setuptools, which has security implications. |
|
@jonparrott Any objection to my merging this? |
|
@lukesneeringer I wanted to give this a test with some older pips. |
|
@david-gang thanks for doing this! |
5 participants
According to this comment the current extras_require format to specify platform dependencies is deprecated, so moving it upwards
Also look here at the documentation and at SO